consensus: set last_block_index during CheckCommits #1960
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AnnaShaleva
force-pushed
the
dbft/set_last_block_time_during_checkcommits
branch
from
5ba597e to
7f3e00b
Compare
erikzhang
reviewed
Sep 25, 2020
This commit makes block time closer to the desired MillisecondsPerBlock value provided via node configuration. It also allows the node to work more instead of waiting for a timer.
AnnaShaleva
force-pushed
the
dbft/set_last_block_time_during_checkcommits
branch
from
7f3e00b to
899655a
Compare
shargon
approved these changes
Sep 25, 2020
erikzhang
approved these changes
Sep 25, 2020
roman-khimov
added a commit
to nspcc-dev/dbft
that referenced
this pull request
Sep 25, 2020
Make block timing more accurate under load. BlockIndex is needed to distinguish between consensus-produced block and the one added via regular block addition mechanism. See neo-project/neo#1959 and neo-project/neo#1960.
This was referenced Dec 9, 2020
Closed
45 tasks
2 tasks
ShawnYun
pushed a commit
to ShawnYun/neo
that referenced
this pull request
Jan 8, 2021
5 tasks
cloud8little
pushed a commit
to cloud8little/neo
that referenced
this pull request
Jan 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit makes block time closer to the desired MillisecondsPerBlock
value provided via node configuration. It also allows the node to work
more instead of waiting for a timer.
This PR will close #1959.