Sender from signers #1752

shargon · 2020-07-07T08:40:37Z

Close #1747

If we are all agree I can fix the UT

erikzhang

If so, the Signers is not an optional field, and should be moved from the Attributes.

shargon · 2020-07-07T09:11:10Z

If so, the Signers is not an optional field, and should be moved from the Attributes.

Agree, what do you prefer @erikzhang ?

src/neo/Network/P2P/Payloads/Transaction.cs

Tommo-L · 2020-07-07T09:55:58Z

If so, could move Witness into Signer?

erikzhang · 2020-07-07T09:57:37Z

If so, could move Witness into Signer?

Of course not.

shargon · 2020-07-07T15:19:50Z

@roman-khimov do you think that it will improve if Signers are moved outside Attributes?

roman-khimov · 2020-07-07T16:00:47Z

@roman-khimov do you think that it will improve if Signers are moved outside Attributes?

Well, we're losing a byte this way for signers array length, but we're also gaining it for signer attribute type, so in the case of a single Sender it doesn't change anything from the resulting transaction's length point of view. But if we're to have more signers, we'll have to add an excessive byte for signer attribute type for each sender and it will make attribute-based serialization scheme a bit less efficient. Also, a transaction has to have a Sender anyway and attributes are considered to be optional in general, so putting something mandatory there seems a bit wrong. And they could also be interleaved with other attributes which just doesn't look good.

So I think moving them outside of attributes makes for a more clear picture: every transaction has Senders, they're ordered (matching the respective witnesses) and there is nothing else there like some other attributes. And attributes are left for some optional additional functionality.

erikzhang · 2020-07-08T05:35:55Z

Let's move them out.

vncoelho · 2020-07-08T12:25:26Z

If so, the Signers is not an optional field, and should be moved from the Attributes.

I agree with this and with the array.

shargon · 2020-07-08T15:03:23Z

Please take a look before fix the UT

src/neo/Network/P2P/Payloads/Transaction.cs

erikzhang · 2020-07-09T09:14:58Z

Need to add a new flag to WitnessScope. None or FeeOnly?

shargon · 2020-07-09T09:42:59Z

FeeOnly it's good

src/neo/Network/P2P/Payloads/Transaction.cs

erikzhang · 2020-07-10T08:43:47Z

You are right. The first can be anything.

src/neo/Wallets/Wallet.cs

shargon · 2020-07-11T08:03:51Z

@roman-khimov could you check it?

ProDog · 2020-07-14T06:36:54Z

TransactionAttribute still useful?🤔

erikzhang · 2020-07-14T07:01:45Z

It is used in Oracle.

* Allow call from native contract (#1700) * Fix MethodCallback (#1723) * Fix #1714 (#1715) * Add base64 SYSCALLs (#1717) * Neo.VM.3.0.0-CI00230 (#1725) * Allow to iterate buffer (#1726) * Buffer iterator * Rename * Remove using Co-authored-by: Erik Zhang <[email protected]> * Update StorageContext.cs (#1728) StorageContext needs to be public so it can be accessed by Neo Debugger Co-authored-by: Erik Zhang <[email protected]> * Fix return value check (#1730) Co-authored-by: Shargon <[email protected]> * Fix ContractEventDescriptor (#1733) * fix enumerator (#1744) Co-authored-by: Tommo-L <[email protected]> * Change json fields to all lower case for consistency (#1736) * Replace DataCache.Find by DataCache.Seek (#1740) * replace DataCache.Find by DataCache.Seek * fix order * optimize * Update ByteArrayComparer.cs * Update ByteArrayComparer.cs * Update DataCache.cs * fix comments * fix comments * fix comments * Update DataCache.cs * Update DataCache.cs * Reorder methods Co-authored-by: Tommo-L <[email protected]> Co-authored-by: erikzhang <[email protected]> Co-authored-by: Shargon <[email protected]> * Add MaxVerificationGas (#1745) Co-authored-by: Shargon <[email protected]> * Create KeyBuilder (#1748) * Speed up the initialization of ApplicationEngine. (#1749) * Change nef checksum to double SHA256 (#1751) * Change to double SHA256 * Clean code * Revert change * Clean code * Fix checksum * Update NefFile.cs * Fix compile * Clean code Clean code Fix checksum Update NefFile.cs Fix compile * Optimize * Optimize * Fix Co-authored-by: erikzhang <[email protected]> * Check witnesses on isStandard (#1754) * Check witness on isStandard * Add IsDeployed * Add IsPayable * Fix UT * format * Add coverage * Remove IsPayable, IsDeployed * Move NEP10 to manifest (#1729) * NEP10 abi * To lower case * Move to Manifest * Clean code * Update ContractManifest.cs * Update ContractManifest.cs * Fix native contracts Co-authored-by: Erik Zhang <[email protected]> * Capture fault Exception (#1761) * Capture faultException * Update Wallet error * Remove flag check * Clean code * Sender from signers (#1752) * Sender from signers * Remove co- * Move signers outside attributes * Fix UT and remove Signers class * Fix UT * Add FeeOnly scope * Remove orderBy * Remove _signersCache * Fix Signers * Fix WitnessScope * Fix Sender * Update TransactionAttributeType.cs * Update Wallet.cs * Fix Wallet * Rename * Update Wallet.cs * Update Wallet.cs * Partial UT fix * More UT fixes * Fix Sender's WitnessScope * Fix Wallet * Fix UT * Explicit FeeOnly for DeployNativeContracts * Same order as serialization * Test FeeOnly * dotnet format * format Co-authored-by: Erik Zhang <[email protected]> * IApplicationEngineProvider (#1758) * Remove the lock from SendersFeeMonitor and rename it to TransactionVerificationContext (#1756) * Add EffectiveVoterTurnout (#1762) * Remove AllowedTriggers from SYSCALLs (#1755) * fix validatorscount (#1770) Co-authored-by: Tommo-L <[email protected]> * impl SeekInternal Co-authored-by: Erik Zhang <[email protected]> Co-authored-by: Shargon <[email protected]> Co-authored-by: Harry Pierson <[email protected]> Co-authored-by: Luchuan <[email protected]> Co-authored-by: Tommo-L <[email protected]> Co-authored-by: joeqian <[email protected]>

* Allow call from native contract (#1700) * Fix MethodCallback (#1723) * Fix #1714 (#1715) * Add base64 SYSCALLs (#1717) * Neo.VM.3.0.0-CI00230 (#1725) * Allow to iterate buffer (#1726) * Buffer iterator * Rename * Remove using Co-authored-by: Erik Zhang <[email protected]> * Update StorageContext.cs (#1728) StorageContext needs to be public so it can be accessed by Neo Debugger Co-authored-by: Erik Zhang <[email protected]> * Fix return value check (#1730) Co-authored-by: Shargon <[email protected]> * Fix ContractEventDescriptor (#1733) * fix enumerator (#1744) Co-authored-by: Tommo-L <[email protected]> * Change json fields to all lower case for consistency (#1736) * Replace DataCache.Find by DataCache.Seek (#1740) * replace DataCache.Find by DataCache.Seek * fix order * optimize * Update ByteArrayComparer.cs * Update ByteArrayComparer.cs * Update DataCache.cs * fix comments * fix comments * fix comments * Update DataCache.cs * Update DataCache.cs * Reorder methods Co-authored-by: Tommo-L <[email protected]> Co-authored-by: erikzhang <[email protected]> Co-authored-by: Shargon <[email protected]> * Add MaxVerificationGas (#1745) Co-authored-by: Shargon <[email protected]> * Create KeyBuilder (#1748) * Speed up the initialization of ApplicationEngine. (#1749) * Change nef checksum to double SHA256 (#1751) * Change to double SHA256 * Clean code * Revert change * Clean code * Fix checksum * Update NefFile.cs * Fix compile * Clean code Clean code Fix checksum Update NefFile.cs Fix compile * Optimize * Optimize * Fix Co-authored-by: erikzhang <[email protected]> * Check witnesses on isStandard (#1754) * Check witness on isStandard * Add IsDeployed * Add IsPayable * Fix UT * format * Add coverage * Remove IsPayable, IsDeployed * Move NEP10 to manifest (#1729) * NEP10 abi * To lower case * Move to Manifest * Clean code * Update ContractManifest.cs * Update ContractManifest.cs * Fix native contracts Co-authored-by: Erik Zhang <[email protected]> * Capture fault Exception (#1761) * Capture faultException * Update Wallet error * Remove flag check * Clean code * Sender from signers (#1752) * Sender from signers * Remove co- * Move signers outside attributes * Fix UT and remove Signers class * Fix UT * Add FeeOnly scope * Remove orderBy * Remove _signersCache * Fix Signers * Fix WitnessScope * Fix Sender * Update TransactionAttributeType.cs * Update Wallet.cs * Fix Wallet * Rename * Update Wallet.cs * Update Wallet.cs * Partial UT fix * More UT fixes * Fix Sender's WitnessScope * Fix Wallet * Fix UT * Explicit FeeOnly for DeployNativeContracts * Same order as serialization * Test FeeOnly * dotnet format * format Co-authored-by: Erik Zhang <[email protected]> * IApplicationEngineProvider (#1758) * Remove the lock from SendersFeeMonitor and rename it to TransactionVerificationContext (#1756) * Add EffectiveVoterTurnout (#1762) * Remove AllowedTriggers from SYSCALLs (#1755) * fix validatorscount (#1770) Co-authored-by: Tommo-L <[email protected]> * workflows: use checkout action v2 (#1775) * Update git workflow * Update .github/workflows/main.yml Co-authored-by: Erik Zhang <[email protected]> Co-authored-by: Erik Zhang <[email protected]> * Add cache to native contract executions V2 (#1766) * cache v2 * More optimizations * Policy contract optimization * Remove interporable variable * Two more * Add Set * Optimizations * Optimize Co-authored-by: erikzhang <[email protected]> * Optimize attributes (#1774) * Add length before compression data (#1768) * Add length before compression * Optimize * Fix UT * Add UT * Add UT Co-authored-by: erikzhang <[email protected]> * Fix VerifyWitnesses (#1776) * Ensure non predictable peers (#1739) * Plugins from List to array * Move false to init * Fix UT * Refactor * Add Exception Message For CreateContract (#1787) * Add Exception Message When Create Contract * Add Exception Message * Code optimization * add UT Co-authored-by: Shargon <[email protected]> Co-authored-by: Qiao Jin <[email protected]> Co-authored-by: Erik Zhang <[email protected]> Co-authored-by: Shargon <[email protected]> Co-authored-by: Harry Pierson <[email protected]> Co-authored-by: Luchuan <[email protected]> Co-authored-by: Tommo-L <[email protected]> Co-authored-by: joeqian <[email protected]> Co-authored-by: cloud8little <[email protected]> Co-authored-by: Qiao Jin <[email protected]>

Closes #1184 Ported changes from neo-project/neo#1752

ryanfalzon · 2020-08-18T16:39:15Z

Can someone please update the documentation to reflect changes done in this pull request. Haver been tyring to understand how to use the new TransactionManager but have been receiving error 500 Invalid from the JSON RPC.

shargon added 2 commits July 7, 2020 10:39

Sender from signers

3702164

Remove co-

576973b

erikzhang reviewed Jul 7, 2020

View reviewed changes

roman-khimov reviewed Jul 7, 2020

View reviewed changes

src/neo/Network/P2P/Payloads/Transaction.cs Outdated Show resolved Hide resolved

shargon and others added 2 commits July 8, 2020 16:16

Merge branch 'master' into sender-from-signers

a618ebf

Move signers outside attributes

4d70d15

Tommo-L reviewed Jul 9, 2020

View reviewed changes

src/neo/Network/P2P/Payloads/Transaction.cs Outdated Show resolved Hide resolved

Tommo-L mentioned this pull request Jul 9, 2020

Neo3-Preview3 release checklist #1731

Closed

16 tasks

Fix UT and remove Signers class

d775492

shargon added the Backward-Incompatible label Jul 9, 2020

Fix UT

fc6a3fa

roman-khimov reviewed Jul 9, 2020

View reviewed changes

src/neo/Network/P2P/Payloads/Transaction.cs Outdated Show resolved Hide resolved

shargon and others added 8 commits July 9, 2020 16:55

Add FeeOnly scope

ec0262e

Remove orderBy

09860a4

Merge branch 'master' into sender-from-signers

f4a6205

Remove _signersCache

a726699

Fix Signers

67dc7e3

Fix WitnessScope

881fb88

Fix Sender

e55dfee

Update TransactionAttributeType.cs

e28cd1d

Fix Sender's WitnessScope

eea80a2

erikzhang reviewed Jul 10, 2020

View reviewed changes

src/neo/Wallets/Wallet.cs Outdated Show resolved Hide resolved

erikzhang and others added 8 commits July 10, 2020 17:48

Fix Wallet

cf8ffba

Fix UT

6b4a56b

Explicit FeeOnly for DeployNativeContracts

a2ae4a2

Same order as serialization

f09a8a5

Test FeeOnly

4870875

Merge branch 'master' into sender-from-signers

abc7999

dotnet format

cb8f978

format

be47d0d

erikzhang approved these changes Jul 10, 2020

View reviewed changes

roman-khimov approved these changes Jul 11, 2020

View reviewed changes

shargon merged commit c4799e9 into neo-project:master Jul 11, 2020

shargon deleted the sender-from-signers branch July 11, 2020 09:24

ProDog mentioned this pull request Jul 13, 2020

apply signers neo-project/neo-node#622

Merged

ProDog mentioned this pull request Jul 14, 2020

update signers for invokefunction and invokescript neo-project/neo-modules#286

Merged

AnnaShaleva added a commit to nspcc-dev/neo-go that referenced this pull request Jul 30, 2020

core: move transaction's sender to cosigners

28520a2

Closes #1184 Ported changes from neo-project/neo#1752

ixje mentioned this pull request Jul 31, 2020

Merge transaction sender and cosigner CityOfZion/neo-mamba#9

Closed

AnnaShaleva added a commit to nspcc-dev/neo-go that referenced this pull request Aug 4, 2020

core: move transaction's sender to cosigners

dae7eef

Closes #1184 Ported changes from neo-project/neo#1752

AnnaShaleva added a commit to nspcc-dev/neo-go that referenced this pull request Aug 4, 2020

core: move transaction's sender to cosigners

9c09743

Closes #1184 Ported changes from neo-project/neo#1752

AnnaShaleva added a commit to nspcc-dev/neo-go that referenced this pull request Aug 4, 2020

core: move transaction's sender to cosigners

8d30a96

Closes #1184 Ported changes from neo-project/neo#1752

AnnaShaleva added a commit to nspcc-dev/neo-go that referenced this pull request Aug 4, 2020

core: move transaction's sender to cosigners

90825ef

Closes #1184 Ported changes from neo-project/neo#1752

ixje mentioned this pull request Oct 2, 2020

Remove sender from invoke* RPCs neo-project/neo-modules#351

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Sender from signers #1752

Sender from signers #1752

shargon commented Jul 7, 2020

erikzhang left a comment

shargon commented Jul 7, 2020

Tommo-L commented Jul 7, 2020

erikzhang commented Jul 7, 2020

shargon commented Jul 7, 2020

roman-khimov commented Jul 7, 2020 •

edited

Loading

erikzhang commented Jul 8, 2020

vncoelho commented Jul 8, 2020 •

edited

Loading

shargon commented Jul 8, 2020

erikzhang commented Jul 9, 2020

shargon commented Jul 9, 2020

erikzhang commented Jul 10, 2020 •

edited

Loading

shargon commented Jul 11, 2020

ProDog commented Jul 14, 2020

erikzhang commented Jul 14, 2020

ryanfalzon commented Aug 18, 2020

Sender from signers #1752

Sender from signers #1752

Conversation

shargon commented Jul 7, 2020

erikzhang left a comment

Choose a reason for hiding this comment

shargon commented Jul 7, 2020

Tommo-L commented Jul 7, 2020

erikzhang commented Jul 7, 2020

shargon commented Jul 7, 2020

roman-khimov commented Jul 7, 2020 • edited Loading

erikzhang commented Jul 8, 2020

vncoelho commented Jul 8, 2020 • edited Loading

shargon commented Jul 8, 2020

erikzhang commented Jul 9, 2020

shargon commented Jul 9, 2020

erikzhang commented Jul 10, 2020 • edited Loading

shargon commented Jul 11, 2020

ProDog commented Jul 14, 2020

erikzhang commented Jul 14, 2020

ryanfalzon commented Aug 18, 2020

roman-khimov commented Jul 7, 2020 •

edited

Loading

vncoelho commented Jul 8, 2020 •

edited

Loading

erikzhang commented Jul 10, 2020 •

edited

Loading