Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Nep11Token #1670
Add Nep11Token #1670
Changes from 116 commits
22469d3
8b0565c
643b566
c45940d
252480d
6a9c7c9
815f1d7
dd0cb86
51ab9a3
5afec85
635c41a
62b33a1
ec3dd26
14a14d7
634d3e3
b23f7a4
9e24c15
fa60149
d16096d
77ebfd3
31bc011
d2c0dd6
6b5783b
cf9ed6e
46a0981
b62cd60
e4aef91
d6b5051
28b7c40
3645e39
a7b96fc
5d291dd
41f493f
d10e4a8
529d730
3226cd5
ae5ed65
af418e6
5bc2345
b689e2f
4e3a966
3ddbaf3
acf1cbb
ea974b7
e35cab8
cca7086
c3d9d28
de49064
8e76e90
0283d0d
c09f8fa
58c8b19
c716579
70be161
14f3219
cc6f4cb
6c8fe32
fd240e2
0b196a8
577a877
8ca85f6
96b34d5
ebaa66f
b2fc4a7
b57ce76
f341213
8e88558
47cda90
cca3209
b2aec08
dfd15b3
583a875
bd1de48
96e9d83
76c2291
ed6e402
9d47028
30766fe
e8a39f8
5e34a29
9f6fef6
d2cdcb9
7d29183
94948b4
13e4660
dcb2b52
10dac9b
f29bd9b
ea0ca45
9720b58
19e7d17
e1bc6d6
30206f0
23a23ca
da94b8b
171e9b9
3d49819
5355bc8
7ea6638
adf9c4d
1506cbc
ab7287c
d87a15e
7a9d11c
a19dfda
c24af36
66b76d3
9bbb6ee
405a4e7
718404f
efdcd9a
8ce35ba
d964521
9f8149a
e1335f1
4efb913
26382c6
07921ba
56025de
f2c1ad4
63ebdb2
a5ac5b1
30c2def
e034c54
6c11a4c
d5c5d5c
7f8489f
c1ca1ad
b7d8758
c695cc1
333f255
844b6d7
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can remove this const
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IEnumerable<StackItem>
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Accorging to
https://github.com/neo-project/proposals/pull/41/files?short_path=afd2225#diff-afd22253b102da74b022d8c022201ee6
The parameter tokenid SHOULD be a valid NFT. If not, this method SHOULD throw an exception.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the owner it's the second in the enumerator?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It has only one owner, when
Decimals = 0
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will not happen, because in this contract NFT is restricted to be indivisible, so there is no second owner.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Then why the enumerator?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need
IEnumerator
fortokensOf
methods of nep11 .There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we can use
UInt160
as the return type of the internaltokensOf
, it's ok for me.