Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce fee (Step1) #1449

Closed

Conversation

bettybao1209
Copy link
Contributor

@bettybao1209 bettybao1209 commented Feb 19, 2020

close #1433.
We aims to fix the issue by two steps. This pr is the first step by directly adjusting the overhigh cost.

Here is the rule of adjusting prices.
For InteropService:

  1. reduce the price by 10 times if the price is lower than 0.00001000;
  2. reduce the price by 100 times, otherwise;
  3. reduce the price of Vote, GetRegisteredValidators, GetValidators, GetNextBlockValidators methods in NeoToken to 0_00080000, 0_00050000, 0_00050000, 0_00030000 respectively;
  4. reduce the price of feePerByte in PolicyContract to 0.00000100.

For OpCode:

  1. reduce the price by 10 times if the price is lower than 0.00000800;
  2. reduce the price by 100, otherwise.

Next, we will implement a contract to dynamically adjust the price of InteropService and OpCode.

@bettybao1209 bettybao1209 changed the title Reduce fee directly (option1) Reduce fee (Step1) Feb 19, 2020
@shargon
Copy link
Member

shargon commented Feb 19, 2020

I remember that @erikzhang have a tool for compute this prices, this tool was adjusted or only was reduced?

@@ -11,18 +11,18 @@ partial class InteropService
{
public static class Storage
{
public const long GasPerByte = 100000;
public const long GasPerByte = 1000;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should be more careful with this in particular, maybe it's a big change

@shargon
Copy link
Member

shargon commented Feb 21, 2020

If we merge #1428 remember to recalculate it before merge this

@erikzhang erikzhang closed this Feb 21, 2020
@Tommo-L
Copy link
Contributor

Tommo-L commented Feb 21, 2020

Why?
Could we implement a contract to dynamically adjust the price of InteropService and OpCode?

@bettybao1209 bettybao1209 deleted the direct-fee-reduce branch February 26, 2020 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reduce transaction fees
4 participants