Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Contract Guid by counter #1405

Merged
merged 24 commits into from
Jan 17, 2020
Merged

Contract Guid by counter #1405

merged 24 commits into from
Jan 17, 2020

Conversation

doubiliu
Copy link
Contributor

Use global counters to implement Guid.

Tommo-L
Tommo-L reviewed Jan 11, 2020
View reviewed changes
src/neo/Persistence/ClonedView.cs Outdated Show resolved Hide resolved
src/neo/Persistence/ReadOnlyView.cs Outdated Show resolved Hide resolved
src/neo/Ledger/GlobalVariableState.cs Outdated Show resolved Hide resolved
src/neo/Persistence/StoreView.cs Outdated Show resolved Hide resolved
@shargon
Copy link
Member

shargon commented Jan 13, 2020

It's ready to review?

@doubiliu doubiliu changed the title Contract guid fix Contract Guid by counter Jan 14, 2020
@doubiliu doubiliu marked this pull request as ready for review January 14, 2020 03:01
@doubiliu doubiliu mentioned this pull request Jan 14, 2020
Merged
eryeer
eryeer reviewed Jan 14, 2020
View reviewed changes
src/neo/Persistence/Prefixes.cs Outdated Show resolved Hide resolved
src/neo/Persistence/ReadOnlyView.cs Outdated Show resolved Hide resolved
src/neo/Persistence/StoreView.cs Outdated Show resolved Hide resolved
src/neo/SmartContract/InteropService.Contract.cs Outdated Show resolved Hide resolved
erikzhang
erikzhang reviewed Jan 14, 2020
View reviewed changes
src/neo/Ledger/ContractState.cs Outdated Show resolved Hide resolved
src/neo/Ledger/ContractIdState.cs Outdated Show resolved Hide resolved
src/neo/Ledger/ContractIdState.cs Outdated Show resolved Hide resolved
src/neo/Ledger/StorageKey.cs Outdated Show resolved Hide resolved
src/neo/SmartContract/InteropService.Contract.cs Outdated Show resolved Hide resolved
src/neo/SmartContract/InteropService.Contract.cs Outdated Show resolved Hide resolved
src/neo/SmartContract/Native/NativeContract.cs Outdated Show resolved Hide resolved
vncoelho
vncoelho approved these changes Jan 14, 2020
View reviewed changes
Copy link
Member

@vncoelho vncoelho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that we can merge this one for moving forward and improve the other opened PR.

erikzhang
erikzhang previously requested changes Jan 15, 2020
View reviewed changes
src/neo/SmartContract/InteropService.Contract.cs Outdated Show resolved Hide resolved
@erikzhang erikzhang merged commit 9a272e1 into neo-project:contract-guid Jan 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tommo-L Tommo-L Tommo-L left review comments

@eryeer eryeer eryeer left review comments

@vncoelho vncoelho vncoelho approved these changes

@shargon shargon shargon approved these changes

@erikzhang erikzhang erikzhang left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@doubiliu @shargon @erikzhang @vncoelho @eryeer @Tommo-L