Rpc limits (2x)

[shargon]

Close #1393 for 2x

#TODO Trying to find the best way for add a read Timeout @Tommo-L could you help me with this?

[superboyiii]

I'll make test on this PR. It will take several hours.

[superboyiii]

@shargon Can we make options.Limits.MaxConcurrentConnections be got from config.json? If it's from Peer.DefaultMaxConnections (now it's 40), I think it's will be a limit of TPS which might not be a good solution. We'd better make it optional.

[superboyiii]

@shargon I've made test on MaxConcurrentConnections and set it to 2 on config.json. It seems doesn't work. I tried to make 12 thread groups in one second. And in every thread group, I made 10 users. I post these requests in one second. However, all requests returned back within correct responses.



By the way, Shall MaxConcurrentConnections not be defined in setting.cs?

[shargon]

I've made test on MaxConcurrentConnections and set it to 2 on config.json. It seems doesn't work. I tried to make 12 thread groups in one second. And in every thread group, I made 10 users. I post these requests in one second. However, all requests returned back within correct responses.

This require an extra change in neo-cli, here we only can allow to be configured, but the config of RPC is on neo-cli

[Tommo-L]

This require an extra change in neo-cli, here we only can allow to be configured, but the config of RPC is on neo-cli

If so, I suggest adding MaxConcurrentConnections on Neo3, not on Neo2.x, otherwise we need to update the neo-cli.

[superboyiii]

I've made test on MaxConcurrentConnections and set it to 2 on config.json. It seems doesn't work. I tried to make 12 thread groups in one second. And in every thread group, I made 10 users. I post these requests in one second. However, all requests returned back within correct responses.

This require an extra change in neo-cli, here we only can allow to be configured, but the config of RPC is on neo-cli

Yes, for this PR, I tested it and it worked as expected. But to user friendly, I think we should open an interface on config.json of node and return the authority to users. Otherwise, it's impossible to ask a user to change the code of neo and make it as a dependency of neo-cli, then publish neo-cli by themselves.

[shargon]

If so, I suggest adding MaxConcurrentConnections on Neo3, not on Neo2.x, otherwise we need to update the neo-cli.

Now it's like this, you can do that or not, but if we won't change neo-cli, we can't configure it, it will take the default value

[erikzhang]

Please, don't waste your time on 2.x.

[superboyiii]

@erikzhang @shargon Shall we go on this PR or stop? Whatever, it pass the test.

[shargon]

If it pass, I think that should be merged, it's already done

[vncoelho]

It is a simple change, no bad trade-off.