Added some limits in 2x #1376
Merged
Added some limits in 2x #1376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shargon
changed the title
Tommo-L
reviewed
Dec 29, 2019
Tommo-L
approved these changes
Jan 2, 2020
|
@superboyiii could you test the backward compatibility? |
I'll test it, need about 2-3 days for chain sync. |
|
TestResults: It is strange that this pr is compatible with pr 1369 both on mainnet and testnet. |
|
Are the same differences than #1369 (comment) ? seems very strange to me :S |
Yes, I don't know why... Actually it's very strange to me, too. |
|
@shargon Will you go on with this pr or close it? |
|
I think that should be merged @nicolegys |
|
Compatibility test pass. See reason on #1369 (comment) |
|
Ready to merge? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #1375
Ensure that MerkleBlockPayload fit the expected values