Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A conflict comes out in NEO3 if an external node make transaction via a wallet which is opened by consensus node at the same time #970

Closed
superboyiii opened this issue Jul 31, 2019 · 3 comments
Labels
Under Investigation The problem mentioned, or possible improvement, is under investigation

Comments

@superboyiii
Copy link
Member

A conflict comes out in NEO3 if an external node makes transaction via a wallet which is opened by consensus node at the same time. Consensus node shows "An item with the same key has already been added.", like this:
image
In external node, the tx was created successfully. They're using the same wallet 1.json. The 100 million NEO is need to be claimed from that wallet.
image

@shargon
Copy link
Member

shargon commented Jul 31, 2019

How could be repeated the hash in mempool? I understand that the error was thrown here

Transactions = transactions.ToDictionary(p => p.Hash);

@lock9 lock9 added the Under Investigation The problem mentioned, or possible improvement, is under investigation label Jul 31, 2019
@superboyiii
Copy link
Member Author

@shargon Yes, you're right. There're two same transactions in the dictionary when ConsensusPayload MakePrepareRequest().
image

@superboyiii
Copy link
Member Author

Seems it's a matter of SimplePolicy. Now I removed it, cli works. I will close this PR since SimplePolicy was already removed.

Thacryba pushed a commit to simplitech/neo that referenced this issue Feb 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Under Investigation The problem mentioned, or possible improvement, is under investigation
Projects
None yet
Development

No branches or pull requests

3 participants