Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Core Plugin] Release Plugin along with Neo-Node #3611

Open
Jim8y opened this issue Dec 5, 2024 · 2 comments
Open

[Core Plugin] Release Plugin along with Neo-Node #3611

Jim8y opened this issue Dec 5, 2024 · 2 comments
Labels
Discussion Initial issue state - proposed but not yet accepted

Comments

@Jim8y
Copy link
Contributor

Jim8y commented Dec 5, 2024

Summary or problem description
A good design of having neo plugin, but now it only cause the system hard to use, hard to maintain, hard to setup. We should consider to remove it.

Do you have any solution you want to propose?
To ensure that existing user can still have the same experience, there is no need for us to remove plugin structure, at lease for now. We can release the plugins along with neo-node, and by default we disable those plugins, user can enable them in a config file or from command line.

Why so?

In this way, we only need to release one package, that is neo-cli, user does not need to install plugins manually, for us developers we can directly build our updated plugin into neo-cli and integrate test it with neo-cli, otherwise we will need to manually copy the dll file to the neo-cli folder.

Where in the software does this update applies to?

  • CLI
  • Plugins
@Jim8y Jim8y added the Discussion Initial issue state - proposed but not yet accepted label Dec 5, 2024
@dusmart
Copy link

dusmart commented Dec 6, 2024

Will custom plugins be impacted?

@Jim8y
Copy link
Contributor Author

Jim8y commented Dec 6, 2024

Will custom plugins be impacted?

No, custom plugins can still be installed as usual. Just built in plugins will be released along with the node, disabled by default of cours.e

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Discussion Initial issue state - proposed but not yet accepted
Projects
None yet
Development

No branches or pull requests

2 participants