[Remove] ApplicationLogs from Plugin System

[cschuchardt88]

Description

Removing the plugins will be in a series of one by one.

Removes ApplicationLogs plugin from the Plugin system.

Type of change

• Optimization (the change is only an optimization)
• Style (the change is only a code style for better maintenance or standard purpose)
• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update

How Has This Been Tested?

• Unit Tests

Checklist:

• My code follows the style guidelines of this project
• I have performed a self-review of my code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes
• Any dependent changes have been merged and published in downstream modules

[Jim8y]

will this affect the function in CLI.Plugin? like when we list the plugins, can we still get the ApplicationLogs?

[cschuchardt88]

No you will not see ApplicationLogs in the plugins. Future we will not have plugins. It will be features.

[shargon]

When we talked about moving plugins to release, I didn't know that means removing the plugin and copying the code to core, why?

[Jim8y]

When we talked about moving plugins to release, I didn't know that means removing the plugin and copying the code to core, why?

ref #3611. in the last core-dev meeting we discussed this issue. built-in plugins will be released along with the neo-cli. Version management and release is a task of NGD and this has being discussed with NGD as well. But user experience will be the same, they still see plugins in the plugins folder, still has config and dll. The only difference is they dont need to manually install them, but enable them in a config file.

Just a brief explaination of this:

Plugin system in neo has lost its original intention, we dont really have many plugins out there to manage, just a few of them and they are not big. However, maintaining them is way more complex than having them directly integrated into the neo-cli:

1. the build folders of plugins are seperate from the neo-cli, we can not directly run neo-cli with latest plugin updates. but manually copy them there.

2. the plugin build output has different structure than the actual plugin folder, we need to manually create folder in neo-cli.

3. We have to release neo-cli and plugins seperately, with the same version number, yet everytime when we release neo-cli, we have to release all plugins again, they release seperately.

4. With just a few plugins, user have to install them before using them, as i stated above, we dont have a plugin market with 1000+ plugins, everytime user just install the same plugins.

[cschuchardt88]

When we talked about moving plugins to release, I didn't know that means removing the plugin and copying the code to core, why?

ref #3611. in the last core-dev meeting we discussed this issue. built-in plugins will be released along with the neo-cli. Version management and release is a task of NGD and this has being discussed with NGD as well. But user experience will be the same, they still see plugins in the plugins folder, still has config and dll. The only difference is they dont need to manually install them, but enable them in a config file.

Just a brief explaination of this:

Plugin system in neo has lost its original intention, we dont really have many plugins out there to manage, just a few of them and they are not big. However, maintaining them is way more complex than having them directly integrated into the neo-cli:

1. the build folders of plugins are seperate from the neo-cli, we can not directly run neo-cli with latest plugin updates. but manually copy them there.
2. the plugin build output has different structure than the actual plugin folder, we need to manually create folder in neo-cli.
3. We have to release neo-cli and plugins seperately, with the same version number, yet everytime when we release neo-cli, we have to release all plugins again, they release seperately.
4. With just a few plugins, user have to install them before using them, as i stated above, we dont have a plugin market with 1000+ plugins, everytime user just install the same plugins.

You cant build them to the a different folder like plugins, they will have to be in the same folder as the neo-cli.exe.

[Jim8y]

@cschuchardt88 please dont go this fast, first we only update the output target of the plugins.

[shargon]

How can we distinguish between plugins and released plugins?

[Jim8y]

How can we distinguish between plugins and released plugins?

why would we need to distinguish them? i mean in the future core and plugins will be together, when we release the neo-cli, plugins are in there. Currently i am suffering this plugin system, i need to debug the plugin in a testnet, but i can not do it cause i can not add breakpoint to plugin, have to manually copy the pdb file there.

[cschuchardt88]

How can we distinguish between plugins and released plugins?

why would we need to distinguish them? i mean in the future core and plugins will be together, when we release the neo-cli, plugins are in there. Currently i am suffering this plugin system, i need to debug the plugin in a testnet, but i can not do it cause i can not add breakpoint to plugin, have to manually copy the pdb file there.

You can add a search path for pdb files in the your IDE or debugger.