-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Testnet can break after ContractManagement's update #2673
Comments
Agree. We need versioning... #2632 |
How is the situation on the mainnet? |
Data sync well on mainnet. But the issue still remains when nativecontract update, how will we process neo core update. this issue happens on testnet mainly because a contract update with a method with its parameters count changed from one to three. |
Confirming mainnet operation, it works fine with full stateroot-level compatibility. |
Solved by the new testnet (T5). |
Describe the bug
I'm not sure what's the current C# node (
master
/develop
) behavior is, but it looks like #2653 fix for #2652 breaks testnet chain processing at block 558659. In NeoGo it looks like this:New rules break some old transaction which leads to incorrect GAS balance for an account that is a sender of another transaction in one of subsequent blocks. There is not enough GAS to cover for this transaction fees, so the chain can't be processed.
Expected behavior
I think we need height-dependent logic for it, maybe using
NativeUpdateHistory
.(Optional) Additional context
Please try it on C# node.
The text was updated successfully, but these errors were encountered: