Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ContractManagement deploy/update should require CallFlags.AllowCall #2652

Closed
roman-khimov opened this issue Jan 18, 2022 · 0 comments · Fixed by #2653
Closed

ContractManagement deploy/update should require CallFlags.AllowCall #2652

roman-khimov opened this issue Jan 18, 2022 · 0 comments · Fixed by #2653
Assignees
@shargon

Comments

@roman-khimov
Copy link
Contributor

Describe the bug
deploy and update methods of ContractManagement native contract internally call _deploy method of the deployed/updated contract (if it exists, of course). However, both methods are specified as requiring only CallFlags.States | CallFlags.AllowNotify flags which I think is not correct.

Expected behavior
Have them require CallFlags.All (similar to NEO or GAS transfer methods that also do internal invocations).

Platform:

  • OS: any
  • Version: neo-cli 3.1.0

(Optional) Additional context
Related to nspcc-dev/neo-go#1990.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shargon shargon

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Change Deploy and Update CallFlags shargon/neo
2 participants
@shargon @roman-khimov