Skip to content
This repository has been archived by the owner on Nov 22, 2023. It is now read-only.

Add ABORTMSG & ASSERTMSG #491

Merged
merged 7 commits into from
Jul 20, 2023
Merged

Add ABORTMSG & ASSERTMSG #491

merged 7 commits into from
Jul 20, 2023

Conversation

ixje
Copy link
Contributor

@ixje ixje commented Oct 4, 2022

See neo-project/neo#2782 (comment)
I think there's a big upside in supporting this in terms of improved developer experience by having actual feedback on why the ABORT or ASSERT failed. Hence why I'm trying to keep this going

For example the reason(s) why sending funds to this NFT fails can actually be communicated back to the user without having to run a node yourself in order to be able to read the logs

@shargon
Copy link
Member

shargon commented Jul 17, 2023

@roman-khimov What do you think? I think that we need to move on on this topic

@roman-khimov
Copy link
Contributor

I think it's good. Not sure which order of x and msg on the stack is more appropriate for ASSERTMSG (to make it easier for compilers to use it), but it'll solve the problem anyway.

@ixje
Copy link
Contributor Author

ixje commented Jul 18, 2023

@shargon seems like it can be then merged, right?

Copy link
Member

@AnnaShaleva AnnaShaleva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't have this PR in the v3.6 list. Are we going to include it into 3.6?

@ixje
Copy link
Contributor Author

ixje commented Jul 18, 2023

We don't have this PR in the v3.6 list. Are we going to include it into 3.6?

I'm pushing for it because this feature is very very useful for the Hackathon (and in general) and very easy to implement (at least on the VM side)

@AnnaShaleva
Copy link
Member

I'm pushing for it because this feature is very very useful for the Hackathon (and in general) and very easy to implement (at least on the VM side)

It's OK, I'm just wondering. I also like this feature.

@ixje
Copy link
Contributor Author

ixje commented Jul 19, 2023

@shargon ping ☝️

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants