StatesDumper: fix bug with missing states dumps #568
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It didn't save anything to cache because bs_cache was always empty. As a result, there were no storage dumps on disc. Fixed.
We already have created path inside the HandlePaths method, no need to create it one more time.
|
@shargon Need your review. |
shargon
approved these changes
Mar 22, 2021
joeqian10
pushed a commit
to joeqian10/neo-modules
that referenced
this pull request
Apr 7, 2021
* StatesDumper: fix OnPersistStorage It didn't save anything to cache because bs_cache was always empty. As a result, there were no storage dumps on disc. Fixed. * StatesDumper: fix OnCommitStorage We already have created path inside the HandlePaths method, no need to create it one more time. * fix-format Co-authored-by: superboyiii <[email protected]>
superboyiii
reviewed
Jan 12, 2023
| @@ -90,7 +89,12 @@ private void OnPersistStorage(uint network, DataCache snapshot) | |||
| bs_item["block"] = blockIndex; | |||
| bs_item["size"] = array.Count; | |||
| bs_item["storage"] = array; | |||
| if (!bs_cache.TryGetValue(network, out JArray cache)) | |||
There was a problem hiding this comment.
I think it's here which cause #736 since cache will be cleared when node exit.
This was referenced Jan 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
StatesDumper does not save states dumps (because of #517 changes).
Solution
We need to put states to
bs_cacheeven if it's empty.