Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update onpersist and oncommit #461

Merged
merged 2 commits into from
Jan 13, 2021
Merged

update onpersist and oncommit #461

merged 2 commits into from
Jan 13, 2021

Conversation

bettybao1209
Copy link
Contributor

fix #459

@shargon shargon merged commit 3fdbcf8 into neo-project:master Jan 13, 2021
@bettybao1209 bettybao1209 deleted the fix-nep17tracker branch January 13, 2021 09:16
@cloud8little
Copy link
Contributor

Test Passed.

18c1b7af4f2209dc838080e9aa53494

vncoelho
vncoelho reviewed Jan 13, 2021
View reviewed changes
Copy link
Member

@vncoelho vncoelho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job

@vncoelho
Copy link
Member

Tested and working!

joeqian10 pushed a commit to joeqian10/neo-modules that referenced this pull request Apr 7, 2021
@bettybao1209 @erikzhang @joeqian10
update onpersist and oncommit (neo-project#461)
527b5c6 
* update method

* More fixes

Co-authored-by: Erik Zhang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vncoelho vncoelho vncoelho left review comments

@erikzhang erikzhang erikzhang approved these changes

@shargon shargon shargon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

getnep17balances doest not work on master
5 participants
@bettybao1209 @cloud8little @vncoelho @shargon @erikzhang