Create consensus plugin #453

erikzhang · 2021-01-10T14:08:23Z

No description provided.

erikzhang · 2021-01-10T14:08:45Z

Wait for neo-project/neo#2212

vncoelho

Looks good, I will test tomorrow.

erikzhang · 2021-01-10T14:55:23Z

Wait for neo-project/neo#2213

erikzhang · 2021-01-10T16:59:39Z

Wait for #454

chenzhitong · 2021-01-11T03:13:11Z

Failed to compile (I've updated Neo in NuGet to the latest)

cloud8little · 2021-01-11T07:28:02Z

how to use it to start consensus?

erikzhang · 2021-01-11T07:55:24Z

Plugin.GetService<IConsensusProvider>()?.Start(wallet);

Use this code in cli.

src/dBFT/DBFTPlugin.cs

Tommo-L · 2021-01-11T12:30:30Z

neo-modules.sln

-Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "Neo.Plugins.StateService.Tests", "tests\Neo.Plugins.StateService.Tests\Neo.Plugins.StateService.Tests.csproj", "{149822EC-4E0C-425F-A032-4196B615BFEB}"
+Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "Neo.Plugins.StateService.Tests", "tests\Neo.Plugins.StateService.Tests\Neo.Plugins.StateService.Tests.csproj", "{149822EC-4E0C-425F-A032-4196B615BFEB}"
+EndProject
+Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "dBFT", "src\dBFT\dBFT.csproj", "{90185D3E-4813-4BC1-98FE-26FD34311403}"


Suggested change

Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "dBFT", "src\dBFT\dBFT.csproj", "{90185D3E-4813-4BC1-98FE-26FD34311403}"

Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "dBFT2.0", "src\dBFT\dBFT.csproj", "{90185D3E-4813-4BC1-98FE-26FD34311403}"

?

The project name shouldn't include version number.

vncoelho · 2021-01-11T14:18:35Z

src/dBFT/dBFT/config.json

+{
+  "PluginConfiguration": {
+    "RecoveryLogs": "ConsensusState",
+    "IgnoreRecoveryLogs": false


"StartConsensus": true?

But how do you pass the wallet?

An encapsulated wallet such as RPCServer DummyWallet?

But perhaps we will need to pass the path and password duplicated here...

What are you suggesting, @erikzhang ?

We can register the wallet as a service. But maybe we should do it in another pr.

will we control the start consensus in the plugin config instead of neo-cli config?

I think so, @cloud8little, control it on neo-cli config will be a little bit confusing in my opinion.
It looks like we need to do this extra effort here to create the wallet as a service as Erik mentioned.

@erikzhang,
another way to do could be to create a function here (called GetStartConsensus()) that return true or false (getting there value from the dBFT config file here..

On the neo-node we check if this plugin exist and call this function.
If true calls

cs IConsensusProvider consensus = Plugin.Plugins.OfType<IConsensusProvider>().FirstOrDefault(); consensus?.Start(wallet);

ProDog · 2021-01-12T02:23:09Z

Plugin.GetService<IConsensusProvider>()?.Start(wallet);

Use this code in cli.

Plugin.GetService<T>() is protected.

vncoelho · 2021-01-12T02:24:25Z

I tried without success here as well,@ProDog....aheuahea
Perhaps creating the wallet service for opening here will be a good direction to already merge this PR.

superboyiii · 2021-01-12T02:27:01Z

Plugin.GetService<IConsensusProvider>()?.Start(wallet);

Use this code in cli.

protectedstatic T GetService<T>() -> protected method can't be used in cli straightly.

erikzhang · 2021-01-12T03:59:20Z

IConsensusProvider consensus = Plugin.Plugins.OfType<IConsensusProvider>().FirstOrDefault();
consensus?.Start(wallet);

Use this code.

superboyiii · 2021-01-12T07:53:31Z

I tried it on my local. No error, no consensus, no log.

src/dBFT/DBFTPlugin.cs

superboyiii · 2021-01-12T10:40:11Z

It could work now but I will make deeper test on this.

vncoelho · 2021-01-12T23:40:54Z

Working.

superboyiii · 2021-01-13T08:27:16Z

Test: PASS
I've tried single-cn and multi-cn, on local and online, within straight connection and seed connection, send some txs and make recovery scenario. All these works well.

So, we'll create the start consensus command in another PR, right?

erikzhang · 2021-01-13T09:19:06Z

Ready to review.

src/dBFT/ConsensusService.cs

src/dBFT/DBFTPlugin.cs

vncoelho · 2021-01-13T15:48:39Z

src/dBFT/DBFTPlugin.cs

+        {
+            walletProvider = GetService<IWalletProvider>();
+            if (Settings.Default.AutoStart)
+                walletProvider.WalletOpened += WalletProvider_WalletOpened;


What is this syntax?
WalletProvider_WalletOpened is a function?

vncoelho · 2021-01-13T15:49:29Z

src/dBFT/dBFT/config.json

@@ -1,6 +1,7 @@
 {
  "PluginConfiguration": {
    "RecoveryLogs": "ConsensusState",
-    "IgnoreRecoveryLogs": false
+    "IgnoreRecoveryLogs": false,
+    "AutoStart": false


Why not True as default? Who use the plugin usually will want it true.

vncoelho · 2021-01-13T15:49:52Z

src/dBFT/DBFTPlugin.cs

+                walletProvider.WalletOpened += WalletProvider_WalletOpened;
+        }
+
+        private void WalletProvider_WalletOpened(object sender, Wallet wallet)


What will be the message is wallet closed?

It will pass the wallet with null value.

vncoelho

Tested and worked as expected.

shargon · 2021-01-13T18:45:44Z

Give me one day more for review

superboyiii · 2021-01-14T07:17:46Z

Works well on mine.

src/dBFT/DBFTPlugin.cs

neo-project/neo-modules#453 (comment)

superboyiii · 2021-01-14T08:30:58Z

Works well on mine. Wait for @shargon 's review.

Create consensus plugin

185e10b

vncoelho reviewed Jan 10, 2021

View reviewed changes

superboyiii mentioned this pull request Jan 11, 2021

Preview5 Checklist neo-project/neo#2171

Closed

36 tasks

erikzhang added 3 commits January 11, 2021 11:36

Merge branch 'master' into dBFT

dbac755

Fix

b547c60

Add RecoveryLogs to config.json

29f96e9

shargon reviewed Jan 11, 2021

View reviewed changes

src/dBFT/DBFTPlugin.cs Show resolved Hide resolved

shargon mentioned this pull request Jan 11, 2021

Clean p2p plugin neo-project/neo#2216

Merged

Tommo-L reviewed Jan 11, 2021

View reviewed changes

vncoelho reviewed Jan 11, 2021

View reviewed changes

Update DBFTPlugin.cs

0ba8790

superboyiii reviewed Jan 12, 2021

View reviewed changes

src/dBFT/DBFTPlugin.cs Outdated Show resolved Hide resolved

Fix startup

27296b3

vncoelho previously approved these changes Jan 12, 2021

View reviewed changes

Optimize the logs

8f941d5

erikzhang dismissed vncoelho’s stale review via 8f941d5 January 13, 2021 06:13

Add start command

82e1571

erikzhang dismissed superboyiii’s stale review via 82e1571 January 13, 2021 09:07

shargon previously approved these changes Jan 13, 2021

View reviewed changes

Add AutoStart to config.json

d3c393e

erikzhang dismissed shargon’s stale review via d3c393e January 13, 2021 09:18

Merge branch 'master' into dBFT

8633a06

vncoelho reviewed Jan 13, 2021

View reviewed changes

src/dBFT/ConsensusService.cs Show resolved Hide resolved

vncoelho reviewed Jan 13, 2021

View reviewed changes

src/dBFT/ConsensusService.cs Show resolved Hide resolved

vncoelho reviewed Jan 13, 2021

View reviewed changes

src/dBFT/DBFTPlugin.cs Show resolved Hide resolved

vncoelho reviewed Jan 13, 2021

View reviewed changes

vncoelho previously approved these changes Jan 13, 2021

View reviewed changes

vncoelho mentioned this pull request Jan 14, 2021

Add RPC method getnativecontracts #462

Merged

This comment has been minimized.

Sign in to view

superboyiii reviewed Jan 14, 2021

View reviewed changes

src/dBFT/DBFTPlugin.cs Show resolved Hide resolved

chenzhitong added a commit to chenzhitong/neo-node that referenced this pull request Jan 14, 2021

Update MainService.Plugins.cs

912e8bf

neo-project/neo-modules#453 (comment)

chenzhitong mentioned this pull request Jan 14, 2021

Update MainService.Plugins.cs neo-project/neo-node#713

Merged

Add description

24e313f

erikzhang dismissed vncoelho’s stale review via 24e313f January 14, 2021 08:08

shargon approved these changes Jan 14, 2021

View reviewed changes

Merge branch 'master' into dBFT

3d87003

erikzhang merged commit 2942a29 into master Jan 14, 2021

erikzhang deleted the dBFT branch January 14, 2021 09:15

joeqian10 pushed a commit to joeqian10/neo-modules that referenced this pull request Apr 7, 2021

Create consensus plugin (neo-project#453)

ce66e57

	Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "dBFT", "src\dBFT\dBFT.csproj", "{90185D3E-4813-4BC1-98FE-26FD34311403}"
	Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "dBFT2.0", "src\dBFT\dBFT.csproj", "{90185D3E-4813-4BC1-98FE-26FD34311403}"

Create consensus plugin #453

Create consensus plugin #453

Conversation

erikzhang commented Jan 10, 2021

erikzhang commented Jan 10, 2021

vncoelho left a comment

Choose a reason for hiding this comment

erikzhang commented Jan 10, 2021

erikzhang commented Jan 10, 2021

chenzhitong commented Jan 11, 2021

cloud8little commented Jan 11, 2021

erikzhang commented Jan 11, 2021

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

vncoelho Jan 11, 2021 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

vncoelho Jan 13, 2021 • edited Loading

Choose a reason for hiding this comment

ProDog commented Jan 12, 2021

vncoelho commented Jan 12, 2021

superboyiii commented Jan 12, 2021

erikzhang commented Jan 12, 2021

superboyiii commented Jan 12, 2021 • edited Loading

superboyiii commented Jan 12, 2021 • edited Loading

vncoelho commented Jan 12, 2021 • edited Loading

superboyiii commented Jan 13, 2021 • edited Loading

erikzhang commented Jan 13, 2021

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

vncoelho left a comment • edited Loading

Choose a reason for hiding this comment

shargon commented Jan 13, 2021

This comment has been minimized.

superboyiii commented Jan 14, 2021

superboyiii commented Jan 14, 2021 • edited Loading

vncoelho Jan 11, 2021 •

edited

Loading

vncoelho Jan 13, 2021 •

edited

Loading

superboyiii commented Jan 12, 2021 •

edited

Loading

superboyiii commented Jan 12, 2021 •

edited

Loading

vncoelho commented Jan 12, 2021 •

edited

Loading

superboyiii commented Jan 13, 2021 •

edited

Loading

vncoelho left a comment •

edited

Loading

superboyiii commented Jan 14, 2021 •

edited

Loading