Fix RPCServer configuration falure #217
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erikzhang
reviewed
Apr 8, 2020
|
Please test it. If it works, we can update all the projects. |
nicolegys
approved these changes
Apr 9, 2020
|
Without any log it's hard to know when something was wrong, you can think that it's well configured and it's not |
I'm not sure whether we need to log it, @erikzhang could you give us some advice? |
|
I think it's good to catch exceptions here |
|
The code looks well but I prefer to know get the error, otherwise it's impossible to know where it fail. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #1531