Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add relayresult #200

Closed
wants to merge 28 commits into from
Closed

Add relayresult #200

wants to merge 28 commits into from

Conversation

bettybao1209
Copy link
Contributor

No description provided.

erikzhang
erikzhang requested changes Mar 27, 2020
View reviewed changes
Copy link
Member

@erikzhang erikzhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#197 (comment)

erikzhang
erikzhang previously approved these changes Mar 30, 2020
View reviewed changes
@erikzhang erikzhang dismissed their stale review March 30, 2020 08:59

There should be a dictionary.

chenquanyu
chenquanyu previously approved these changes Mar 30, 2020
View reviewed changes
@vncoelho
Copy link
Member

close #205

@vncoelho vncoelho mentioned this pull request Mar 30, 2020
Closed
@vncoelho
Copy link
Member

I am facing problem to test RpcServer because of the dependencies problem reported on #198, could you give a hand on that @bettybao1209 @superboyiii ?

@nicolegys
Copy link
Contributor

Test passed.

Test steps:

sendrawtransaction

  1. sendrawtransaction - tx not exsited
    result: return tx hash
    image
  2. sendrawtransaction - tx already exsited
    result: return error AlreadyExists
    image

submitblock
1.show state
image
2. submitblock - block not exsited
result: return block hash
image
3.show state
result: block height increased by 1
image
4. submitblock - block already exsited
result: return error AlreadyExists
image
5.show state
result: block height didn't change
image

vncoelho
vncoelho previously approved these changes Mar 31, 2020
View reviewed changes
@nicolegys nicolegys mentioned this pull request Apr 3, 2020
Merged
shargon
shargon reviewed Apr 7, 2020
View reviewed changes
src/RpcServer/RelayActor.cs Outdated Show resolved Hide resolved
@erikzhang erikzhang mentioned this pull request Apr 7, 2020
Closed
shargon
shargon previously approved these changes Apr 8, 2020
View reviewed changes
@Qiao-Jin Qiao-Jin mentioned this pull request Apr 9, 2020
Merged
@erikzhang
Copy link
Member

Please wait for neo-project/neo#1548

@erikzhang
Copy link
Member

neo-project/neo#1548 has been merged.

@bettybao1209
Copy link
Contributor Author

neo-project/neo#1548 has been merged.

Ok, I open a new PR #220 and I'll close this one.

@bettybao1209 bettybao1209 deleted the add-relayreason branch April 13, 2020 02:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erikzhang erikzhang erikzhang left review comments

@chenquanyu chenquanyu chenquanyu left review comments

@vncoelho vncoelho vncoelho left review comments

@shargon shargon shargon left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@bettybao1209 @vncoelho @nicolegys @erikzhang @shargon @chenquanyu