Optimized StorageMap #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erikzhang
reviewed
Aug 25, 2019
|
As @erikzhang said, changes was required for byte to byte[] conversion, also was upgraded the |
erikzhang
previously approved these changes
Aug 26, 2019
|
I changed the unit test to not send the prefix as an argument because it is more real, the byte is considered as an integer, so 0x00 is added at the end. |
shargon
commented
Aug 26, 2019
erikzhang
reviewed
Aug 26, 2019
shargon
commented
Aug 26, 2019
| }; | ||
| } | ||
|
|
||
| public static StorageMap CreateMap(this StorageContext context, byte prefix) |
There was a problem hiding this comment.
I can't find an optimized version of the conversion from byte to byte array inside the VM, should we remove this method?
erikzhang
reviewed
Aug 26, 2019
erikzhang
approved these changes
Aug 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #88