Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update neo 3.6 #758

Merged
merged 7 commits into from
Sep 5, 2023
Merged

Update neo 3.6 #758

merged 7 commits into from
Sep 5, 2023

Conversation

shargon
Copy link
Member

@shargon shargon commented Jun 30, 2022

@devhawk
Copy link
Contributor

devhawk commented Jul 8, 2022

It feels like a better solution to this would be an ABORT with message opcode in NeoVM. Changing the behavior of assert depending on call flags seems sketchy

@shargon shargon changed the title Fix safe assert ASSERTMSG AND ABORTMSG Sep 5, 2023
@shargon shargon requested a review from superboyiii September 5, 2023 07:20
@Jim8y Jim8y mentioned this pull request Sep 5, 2023
@Jim8y
Copy link
Contributor

Jim8y commented Sep 5, 2023

#790 this pr addresses the UT test issue

@shargon shargon changed the title ASSERTMSG AND ABORTMSG Update neo 3.6 Sep 5, 2023
@shargon
Copy link
Member Author

shargon commented Sep 5, 2023

#790 this pr addresses the UT test issue

I already fixed one by one xD, but thanks! it will be merged for future ones. Good fix!

@Jim8y
Copy link
Contributor

Jim8y commented Sep 5, 2023

#790 this pr addresses the UT test issue

I already fixed one by one xD, but thanks! it will be merged for future ones. Good fix!

Its good as long as issues fixed

@shargon shargon merged commit ad66927 into neo-project:master Sep 5, 2023
@shargon shargon deleted the fix-safe-assert branch November 7, 2023 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Assert and Safe methods
3 participants