Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix concat #356

Merged
merged 9 commits into from
Sep 19, 2020
Merged

Fix concat #356

merged 9 commits into from
Sep 19, 2020

Conversation

shargon
Copy link
Member

@shargon shargon commented Sep 15, 2020

Close #355

Tommo-L
Tommo-L previously approved these changes Sep 16, 2020
View reviewed changes
lightszero
lightszero previously approved these changes Sep 16, 2020
View reviewed changes
Copy link
Member

@lightszero lightszero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had fix this a little.
Parse 2string,3string,4string overload.
Add a throw for other overload.
Add parse for String::concat(string[] args).

lightszero
lightszero previously approved these changes Sep 16, 2020
View reviewed changes
Tommo-L
Tommo-L previously approved these changes Sep 16, 2020
View reviewed changes
@erikzhang
Copy link
Member

erikzhang commented Sep 16, 2020 •
edited
Loading

Tested? @neo-project/ngd-shanghai

@shargon shargon dismissed stale reviews from Tommo-L and lightszero via 602159c September 16, 2020 13:31
@shargon
Copy link
Member Author

shargon commented Sep 18, 2020

ready to merge?

@shargon shargon merged commit 511d990 into neo-project:master Sep 19, 2020
@shargon shargon deleted the fix-concat branch September 19, 2020 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erikzhang erikzhang erikzhang approved these changes

@Tommo-L Tommo-L Tommo-L left review comments

@lightszero lightszero lightszero left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Concat string failure
4 participants
@shargon @erikzhang @lightszero @Tommo-L