Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change some native methods to properties #354

Merged
merged 4 commits into from
Sep 20, 2020
Merged

Change some native methods to properties #354

merged 4 commits into from
Sep 20, 2020

Conversation

shargon
Copy link
Member

@shargon shargon commented Sep 12, 2020

  • Changed Name, Symbol and Decimals to properties

@shargon shargon requested a review from erikzhang September 12, 2020 10:53
@shargon shargon requested a review from erikzhang September 18, 2020 09:06
shargon
shargon commented Sep 20, 2020
View reviewed changes
src/Neo.Compiler.MSIL/MSIL/Conv_Multi.cs
}

string methodName = null;
if (method.SemanticsAttributes.HasFlag(MethodSemanticsAttributes.Getter))
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@shargon shargon merged commit ab0afae into neo-project:master Sep 20, 2020
@shargon shargon deleted the use-property branch September 20, 2020 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erikzhang erikzhang erikzhang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shargon @erikzhang