Optimize ROT

[shargon]

Close #245

[ShawnYun]

That looks good

[ShawnYun]

What if there is a JMP case?

[shargon]

What if there is a JMP case?

It won't be a push, it will be a label

[ShawnYun]

For example:

            scriptBefore.Emit(VM.OpCode.PUSH5);
            scriptBefore.Emit(VM.OpCode.PUSH4);
            scriptBefore.EmitJump(VM.OpCode.JMP, 2);
            scriptBefore.Emit(VM.OpCode.PUSH1);
            scriptBefore.Emit(VM.OpCode.PUSH2);
            scriptBefore.Emit(VM.OpCode.PUSH3);
            scriptBefore.Emit(VM.OpCode.ROT);

after optimized, it will be:

            scriptBefore.Emit(VM.OpCode.PUSH5);
            scriptBefore.Emit(VM.OpCode.PUSH4);
            scriptBefore.EmitJump(VM.OpCode.JMP, 2);
            scriptBefore.Emit(VM.OpCode.PUSH2);
            scriptBefore.Emit(VM.OpCode.PUSH3);
            scriptBefore.Emit(VM.OpCode.PUSH1);

?

[shargon]

Yes because the JMP is not in the middle.

Before

After

I added a new UT with JMP,3. Please check it @ShawnYun

[shargon]

Ready to merge?