Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Runtime.GasLeft() #222

Closed
wants to merge 6 commits into from
Closed

Add Runtime.GasLeft() #222

wants to merge 6 commits into from

Conversation

ProDog
Copy link
Contributor

@ProDog ProDog commented Mar 26, 2020

Corresponding PR neo-project/neo#1509

erikzhang
erikzhang previously approved these changes Mar 26, 2020
View reviewed changes
@erikzhang
Copy link
Member

Please fix the format.

@shargon
Copy link
Member

shargon commented Mar 26, 2020 •
edited
Loading

Please wait for #216 (was removed the neo-vm dependency in the csproj)

@shargon
Copy link
Member

shargon commented Mar 26, 2020

@ProDog Could you add some UT ?

@ProDog
Copy link
Contributor Author

ProDog commented Mar 26, 2020

@ProDog Could you add some UT ?

OK,I'll check after #216.

vncoelho
vncoelho reviewed Mar 26, 2020
View reviewed changes
Copy link
Member

@vncoelho vncoelho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job on the speed for testing it on the previous PR.

@ProDog ProDog closed this Mar 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vncoelho vncoelho vncoelho left review comments

@erikzhang erikzhang erikzhang left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ProDog @erikzhang @shargon @vncoelho