Skip to content
This repository has been archived by the owner on Nov 13, 2024. It is now read-only.

Submitblock RPC call documentation is outdated #1111

Closed
roman-khimov opened this issue Jul 22, 2020 · 0 comments
Closed

Submitblock RPC call documentation is outdated #1111

roman-khimov opened this issue Jul 22, 2020 · 0 comments

Comments

@roman-khimov
Copy link
Contributor

It demonstrates boolean return result for successful invocations, but in Neo 3 this call returns a hash, the same way sendrawtransaction does.

superboyiii added a commit that referenced this issue Sep 27, 2020
Celia18305 added a commit that referenced this issue Sep 28, 2020
* Update submitblock.md

Close #1111

* update English file

Co-authored-by: celiayu <[email protected]>
chenzhitong added a commit that referenced this issue Apr 13, 2021
* remove other languages

* updated

* updated

* update faq

* updated

* removed

* fix formatting issues

* fix issues

* update sdk

update deploy contract

* New release neo3 (#1069)

* Update config.json

* update gui doc

* updated

* updated English files

Co-authored-by: 陈志同 <[email protected]>
Co-authored-by: celiayu <[email protected]>

* fix issue

* updated storage

* update contract samples

* add glossary and other updates

* updated FAQ

* remove outdated figures

* updated

* remove outdated files

* remove outdated files

* updated GUI and test net

* Enchance the description of sc development (#1081)

* add comments

* updated

Co-authored-by: celiayu <[email protected]>

* Enhance the fee description of storage.put/putx (#1086)

* enhance fee desc of storage.put

* updated

Co-authored-by: celiayu <[email protected]>

* add faq (#1085)

* update faq

* add cli

* Add governance api (#1087)

Co-authored-by: Jin Qiao <[email protected]>

* updated governance

* updated

* minor updates

* Governance api Illustration (#1089)

* Add governance api

* Governance API Illustration

* Text optimization

* Text optimization

* updated

* updated

Co-authored-by: Jin Qiao <[email protected]>
Co-authored-by: celiayu <[email protected]>

* updated the note

* Update basics.md (#1092)

* Update basics.md

* polished

* update English

Co-authored-by: celiayu <[email protected]>

* rename getunclaimedgas (#1095)

* rename

neo-project/neo-modules#243

* update related files

Co-authored-by: celiayu <[email protected]>

* getbalance update to getwalletbalance (#1094)

* getbalance update to getwalletbalance

https://github.com/neo-project/neo-modules/pull/243/files

* update related files

Co-authored-by: celiayu <[email protected]>

* Update invokefunction.md (#1102)

* Update invokefunction.md

Close:#1098

* update invokescript

* add English changes

Co-authored-by: celiayu <[email protected]>

* Update private chain instructions (#1105)

* Update solo.md

There are some inconsistencies which cause confusion when reading the steps
- in the beginning the wallet is named `1.json` later `a.json`. Fixed to always use `1.json`
- the public key shown in the screenshot is different from the public key used in the remainder of the text. Fixed to use the same
- the final step "withdrawing " doesn't actually show how to withdraw

* update Chinese flie

Co-authored-by: celiayu <[email protected]>

* Update getrawmempool.md (#1107)

* follow up-update getrawmempool

* Release neo3 preview3 (#1120)

* Cli update for preview3 (#1104)

* fix exchange related content

* update cli for preview3

* fix

* update exchange files

* update cli files

Co-authored-by: celiayu <[email protected]>

* update private chain guide (#1106)

* update private chain guide

* Update private-chain2.md

fix

* update

* fix

* updated

* Update solo.md

* updated

Co-authored-by: celiayu <[email protected]>

* Updating transaction, wallet & consensus (#1110)

* Updating transaction, wallet & consensus

* update a portion

* update transaction

Co-authored-by: Jin Qiao <[email protected]>
Co-authored-by: celiayu <[email protected]>

* Modify RPC and VM OPcode (#1112)

* modify RPC and VM OPcode

* update RPC API

* Update getrawtransaction.md

* Update api.md

* Update getapplicationlog.md

* Update getcontractstate.md

* Update getrawtransaction.md

* Update invokefunction.md

* Update invokescript.md

* Update api.md

* Update getapplicationlog.md

* Update getcontractstate.md

* Update getcontractstate.md

* Update getversion.md

* Update invokefunction.md

* Update invokefunction.md

* Update invokescript.md

* Update invokescript.md

* Update sendfrom.md

* Update sendfrom.md

* Update sendmany.md

* Update sendmany.md

* Update sendmany.md

* Update sendtoaddress.md

* Update sendtoaddress.md

* update vm

* Update api.md

* Update sendfrom.md

* Update api.md

* Update sendfrom.md

* updated API

Co-authored-by: celiayu <[email protected]>
Co-authored-by: HaoqiangZhang <[email protected]>

* Release neo3 preview3 sc write part (#1113)

* Update sc write

* update basic type

* fix typo

* Update Contract and Crypto类型

* Update TriggerType, Notification, runtime

* fix type

* Update CreateStandardAccount.md

* Update Contract.md

* Update GetCallFlags.md

* Update Runtime.md

* Update basics.md

* Update System.md

* updated

* updated

* updated

Co-authored-by: HaoqiangZhang <[email protected]>
Co-authored-by: celiayu <[email protected]>

* Add getunclaimedgas (#1115)

* add getunclaimedgas

* update en

* update validator

* update RPC API

* update rpc api (#1117)

* review privatechain (#1119)

* updated

Co-authored-by: Owen Zhang <[email protected]>
Co-authored-by: Qiao Jin <[email protected]>
Co-authored-by: Jin Qiao <[email protected]>
Co-authored-by: ShawnYun <[email protected]>
Co-authored-by: HaoqiangZhang <[email protected]>
Co-authored-by: lichen <[email protected]>

* update toc

* Fix issues in wallet

* Update wallets.md

* update cli commands (#1125)

* update cli commands

* updated and add English updates

Co-authored-by: celiayu <[email protected]>

* update gui 1.1.0 (#1124)

* update gui 1.1.0

* update on GUI docs

* updated

* updated

Co-authored-by: wanglongfei88 <[email protected]>

* Fix issues

* update GUI

* update GUI

* updated exchange

* fix errors

* review private chain (#1126)

* Update solo.md

* updated

* add GUI related info

* add rocksdb (#1127)

* add rocksdb

* Update setup.md

* Update setup.md

Co-authored-by: Celia18305 <[email protected]>

* add sender for rpc api (#1130)

* add sender for rpc api

* update sendmany

* updated

* Update sendmany.md

Co-authored-by: celiayu <[email protected]>

* Update submitblock.md (#1136)

* Update submitblock.md

Close #1111

* update English file

Co-authored-by: celiayu <[email protected]>

* Reorg structure (#1148)

* adjust structure

* update

* fix links

* fix links

* fix links

* Update prerequisites.md

* update English

* reorg

* updated

* fix links

fix links

* Update index.md

* update rpc and sc (#1142)

* update rpc api

* fix

* update sc api

* update sc framework

* update fee

* some updates in develop

* update opcode fee

Co-authored-by: Celia18305 <[email protected]>

* updated

* update api

* Update to the latest. (#1143)

* add oracle

* some updates (#1144)

* update rpc api

* fix

* update sc api

* update sc framework

* update fee

* some updates in develop

* update opcode fee

* update intro

* update nep5

* update sdk

* updated English SDK

* follow up

Co-authored-by: Celia18305 <[email protected]>
Co-authored-by: Celia18305 <[email protected]>

* add oralce

* update toc

* update

* update scapi (#1145)

* update rpc api

* fix

* update sc api

* update sc framework

* update fee

* some updates in develop

* update opcode fee

* update intro

* update nep5

* update sdk

* updated English SDK

* follow up

* update scapi

* update method descriptors

* updated

Co-authored-by: Celia18305 <[email protected]>
Co-authored-by: Celia18305 <[email protected]>

* update setup

* update index

Co-authored-by: cn1010 <[email protected]>
Co-authored-by: Owen Zhang <[email protected]>

* fix issues

* update toc

* update FAQ

* preview4 updates (#1149)

* Sync to Nep17

* fix

* fix issues

* update nep17

* update nep17

* fix issues

* fix nep17 issues

* updated api

* updated

* updated

* update API

* updated

* fix issues

* NEO-191 Fix NEP17 errors in the docs (#1153)

Co-authored-by: luc10921 <[email protected]>

* Release preview5 (#1162)

* Update RPC (#1150)

* update(1/2)

* update(2/2)

* update

* updated api.md

* updated English version

* updated English files

Co-authored-by: Celia18305 <[email protected]>

* opcode price (#1151)

* price

* Update neo_vm.md

Co-authored-by: Celia18305 <[email protected]>

* update neo-cli docs for preview5 (#1154)

* update neo-cli docs

* update neo-cli docs

* update neo-cli docs

* Update cli.md

Co-authored-by: Celia18305 <[email protected]>

* Release preview5 (#1156)

* price

* Update neo_vm.md

* remove

* updated

Co-authored-by: Celia18305 <[email protected]>

* Preview5 smartcontract API and framework (#1152)

* update(1/3)

* update(2/3)

* update

* update (3/3)

* update (4/3)

* finish

* updated English

Co-authored-by: Celia18305 <[email protected]>
Co-authored-by: Celia18305 <[email protected]>

* update neo node docs (#1157)

* update neo node docs

* add maxGAS

* update

* updated

Co-authored-by: Celia18305 <[email protected]>

* add name service api (#1155)

* add name service api

* update

* add english edition of the nns

* minor fix

* fix issues

* Fix precision (#1160)

* update(1/3)

* update(2/3)

* update

* update (3/3)

* update (4/3)

* finish

* update

* fixed

Co-authored-by: Celia18305 <[email protected]>
Co-authored-by: Celia18305 <[email protected]>

* add state root rpc api (#1159)

* add state root rpc api

* update

* update

* updated

Co-authored-by: Celia18305 <[email protected]>
Co-authored-by: Celia18305 <[email protected]>

* update contract framework (#1161)

* update

* Update Transfer.md

* Update Transfer.md

Co-authored-by: Celia18305 <[email protected]>

Co-authored-by: 陈志同 <[email protected]>
Co-authored-by: Shine Li <[email protected]>
Co-authored-by: HaoqiangZhang <[email protected]>
Co-authored-by: cn1010 <[email protected]>

* fix issues

* updated toc

* Create permission.md (#1164)

* Create permission.md

* Add CryptoLib and StdLib

* fixed issues

* updated English files

* updated English files

* update toc

Co-authored-by: Celia18305 <[email protected]>

* update NEP-17 (#1165)

* onNEP17Payment

* changelog

* updated

Co-authored-by: Celia18305 <[email protected]>

* Fee (#1167)

* Create fee.md

* Update fee.md

* updated

* updated

Co-authored-by: Celia18305 <[email protected]>

* nef & manifest (#1170)

* nef & manifest

* updated

Co-authored-by: Celia18305 <[email protected]>

* update gettingstarted (#1171)

* update gettingstarted

* updated

Co-authored-by: Celia18305 <[email protected]>

* contract update and destroy (#1172)

* update

* Update update.md

* updated

Co-authored-by: Celia18305 <[email protected]>

* fix issues

* update (#1173)

* update avm to nef

* fix links

* add nns

* Update calculatenetworkfee.md (#1174)

* Update getblock.md (#1175)

* Update getblockheader.md (#1177)

* Update getcontractstate.md (#1178)

* Update getnativecontracts.md (#1179)

* Update validateaddress.md (#1190)

* Update validateaddress.md

* Update validateaddress.md

Co-authored-by: Celia18305 <[email protected]>

* Update sendtoaddress.md (#1189)

* Update sendmany.md (#1188)

* Update sendfrom.md (#1187)

* Update invokescript.md (#1186)

* Update getwalletbalance.md (#1184)

* updated rpc api

* Update invokecontractverify.md (#1185)

* Update invokecontractverify.md

* Update invokecontractverify.md

* Update invokecontractverify.md

* Update getproof.md (#1182)

* Update getproof.md

* updated

Co-authored-by: Celia18305 <[email protected]>

* Update getnep17balances.md (#1180)

* Update getnep17balances.md

* updated

Co-authored-by: Celia18305 <[email protected]>

* Update neovm.md

* update (#1176)

* Update getnep17transfers.md (#1181)

* Update getnep17transfers.md

* updated

* updated

Co-authored-by: Celia18305 <[email protected]>
Co-authored-by: Celia18305 <[email protected]>

* update (#1183)

Co-authored-by: Celia18305 <[email protected]>

* update faq (#1191)

* update faq

* updated

Co-authored-by: Clay9910 <[email protected]>
Co-authored-by: Celia18305 <[email protected]>

* Update consensus & api (#1192)

* update consensus & api

* correction and translation

* Update consensus_protocol.md

Co-authored-by: Celia18305 <[email protected]>

* Add a note on neofs urls (#1199)

* oracle: add a note on NeoFS URLs

* oracle: add a note on JSON

* update basic block&tx zh-cn (#1194)

* update

* updated

Co-authored-by: Celia18305 <[email protected]>

* update to RC1 (#1200)

* update to RC1

* update private chain

* updated

Co-authored-by: Celia18305 <[email protected]>

* Update wallet (#1198)

* Update wallet

* updated

Co-authored-by: Celia18305 <[email protected]>

* update encryption (#1196)

* update encryption

* updated

Co-authored-by: Celia18305 <[email protected]>

* update docs for the use of endian scriptHas (#1197)

* udpate docs for endian scrip hash

* updated

Co-authored-by: Celia18305 <[email protected]>
Co-authored-by: Celia18305 <[email protected]>

* Update Oracle api (#1195)

* Update Oracle api

* updated

Co-authored-by: Celia18305 <[email protected]>

* Update oracle.md (#1193)

* Update oracle.md

* add figures

* updated

* fix links

* update oracle

* Update governance

* replace name

* fix issues

* update index

* Neo-cli autostart configuration updated (#1201)

That you need to install the DBFTPlugin and set AutoStart to true in the plugin config file is not clear. I updated the documentation to make that more clear.

* update node

* Update oracle.md

* Update setup.md

* fix issues

* Update token_model.md

Old GAS information @Celia18305 - please merge

* Update toc.yml

removed dead link (charging model) @Celia18305

* update token model

* update governance and replace name

* replace name

* fix issue

* updated

* update faq (#1204)

* update faq

* remove sc faq

* update

Co-authored-by: Celia18305 <[email protected]>

* Update basics.md (#1206)

In NEO 3, no overload for method 'Put' of Storage takes 2 arguments. This PR is to fix this compilation error in the example.

* update sdk docs (#1205)

* update sdk docs

* update English

Co-authored-by: ProDog <[email protected]>
Co-authored-by: Celia18305 <[email protected]>

* Update config.json (#1207)

* Update config.json

Co-authored-by: celiayu <[email protected]>
Co-authored-by: wanglongfei88 <[email protected]>
Co-authored-by: ZhangHaoqiang <[email protected]>
Co-authored-by: wanglongfei <[email protected]>
Co-authored-by: 陈志同 <[email protected]>
Co-authored-by: Luchuan <[email protected]>
Co-authored-by: Celia18305 <[email protected]>
Co-authored-by: Qiao Jin <[email protected]>
Co-authored-by: Jin Qiao <[email protected]>
Co-authored-by: cloud8little <[email protected]>
Co-authored-by: Erik van den Brink <[email protected]>
Co-authored-by: Owen Zhang <[email protected]>
Co-authored-by: ShawnYun <[email protected]>
Co-authored-by: lichen <[email protected]>
Co-authored-by: cn1010 <[email protected]>
Co-authored-by: superboyiii <[email protected]>
Co-authored-by: Lucas Kenji Uezu <[email protected]>
Co-authored-by: luc10921 <[email protected]>
Co-authored-by: 陈志同 <[email protected]>
Co-authored-by: Shine Li <[email protected]>
Co-authored-by: Clay9910 <[email protected]>
Co-authored-by: Roman Khimov <[email protected]>
Co-authored-by: ZhangTao <[email protected]>
Co-authored-by: doubiliu <[email protected]>
Co-authored-by: Rene Buunk <[email protected]>
Co-authored-by: fabwa <[email protected]>
Co-authored-by: Wonseok Chae <[email protected]>
Co-authored-by: ProDog <[email protected]>
Co-authored-by: 陈志同 <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants