Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix prob_cleanup #206

Merged
merged 2 commits into from
Aug 27, 2018
Merged

Fix prob_cleanup #206

merged 2 commits into from
Aug 27, 2018

Conversation

jgosmann
Copy link
Collaborator

@jgosmann jgosmann commented Aug 27, 2018

Motivation and context:

This fixes the documentation where one statement was wrong. Also, an exception is raised instead of returning incorrect values, when the calculation fails due to limited floating point precision.

Fixes #203.

Interactions with other PRs:

none

How has this been tested?

added assert in the relevant test

How long should this take to review?

  • Quick (less than 40 lines changed or changes are straightforward)

Where should a reviewer start?

Please make sure that the documentation is actually correct and that I didn't confuse myself in the end.

Types of changes:

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • I have read the CONTRIBUTING.rst document.
  • I have updated the documentation accordingly.
  • I have included a changelog entry.
  • I have added tests to cover my changes.
  • I have run the test suite locally and all tests passed.

@jgosmann jgosmann added this to the 0.6 milestone Aug 27, 2018
@jgosmann jgosmann self-assigned this Aug 27, 2018
@jgosmann jgosmann requested a review from Seanny123 August 27, 2018 20:45
@jgosmann jgosmann removed their assignment Aug 27, 2018
@jgosmann jgosmann merged commit a65a30e into master Aug 27, 2018
@jgosmann jgosmann deleted the fix-prob-cleanup branch August 27, 2018 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Numerical issues with prob_cleanup
2 participants