Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Numerical issues with prob_cleanup #203

Closed
jgosmann opened this issue Jul 26, 2018 · 1 comment · Fixed by #206
Closed

Numerical issues with prob_cleanup #203

jgosmann opened this issue Jul 26, 2018 · 1 comment · Fixed by #206
Labels
bug
Milestone
0.6

Comments

@jgosmann
Copy link
Collaborator

The prob_cleanup can produce misleading results, for example

prob_cleanup(0.2, 2025, np.inf)

returns 1, but the for an inifinite vocabulary, the probability should not be 1.
@jgosmann jgosmann added the bug label Jul 26, 2018
@jgosmann
Copy link
Collaborator Author

Or maybe I'm misunderstanding the documentation ... it is confusing me slightly.

jgosmann added a commit that referenced this issue Aug 27, 2018
@jgosmann
Let prob_cleanup raise exception if inaccurate.
2da500a 
Fixes #203.
@jgosmann jgosmann added this to the 0.6 milestone Aug 27, 2018
@jgosmann jgosmann mentioned this issue Aug 27, 2018
Merged
5 tasks
jgosmann added a commit that referenced this issue Aug 27, 2018
@jgosmann
Let prob_cleanup raise exception if inaccurate.
6633ed1 
Fixes #203.
jgosmann added a commit that referenced this issue Aug 27, 2018
@jgosmann
Let prob_cleanup raise exception if inaccurate.
a65a30e 
Fixes #203.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Milestone
0.6
Development

Successfully merging a pull request may close this issue.

Fix prob_cleanup nengo/nengo-spa
1 participant
@jgosmann