Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Menu dropdown causes any covered links to become unclickable #74

Closed
arvoelke opened this issue May 7, 2019 · 0 comments
Closed

Menu dropdown causes any covered links to become unclickable #74

arvoelke opened this issue May 7, 2019 · 0 comments
Assignees
@krisfrenette
Labels
bug

Comments

@arvoelke
Copy link
Contributor

arvoelke commented May 7, 2019

Steps to reproduce:

  • go to https://www.nengo.ai/documentation.html with full resolution (not the mobile view)
  • mouse-over the "Documentation" menu to trigger the drop down
  • try to click on a link that was just covered by the drop down (e.g., "Quick start guide")

@krisfrenette says the container / background for the dropdown is still present, even after the dropdown appears to go away.
@arvoelke arvoelke added the bug label May 7, 2019
@krisfrenette krisfrenette self-assigned this May 11, 2019
tbekolay added a commit to nengo/nengo-sphinx-theme that referenced this issue May 17, 2019
@tbekolay
squash! Fix for menu dropdown covering content on website issue #74
f507282 
- The next release is 0.11.0, we make an empty section after
  each release to put new changelog entries so an individual
  pull request will never have to start a new changelog entry
  (it's too easy for multiple PRs to have to make a new section,
  which results in merge conflicts)
- Changelog entry had some trailing whitespace, would be good
  to enable "files.trimTrailingWhitespace" (in VSCode)
- Changelog entry was a bit too specific/technical, it should
  be written for the end user (usually dev specific stuff that
  the user doesn't need to know about doesn't even make it
  into the changelog) and without requiring full knowledge of
  the issues list (i.e., what is the "overlay issue"?)
  as we expect the changelog to be read by more users than the
  issues list.

When I squash, I'll change the commit message to be:

Fix menu dropdown covering content after mouseout

Fixes nengo/nengo.github.io#74
@tbekolay tbekolay mentioned this issue May 17, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@krisfrenette krisfrenette

Labels
bug
Milestone
No milestone
Development

No branches or pull requests
2 participants
@arvoelke @krisfrenette