Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Sphinx 7 #80

Merged
merged 4 commits into from
Jan 19, 2024
Merged

Update to Sphinx 7 #80

merged 4 commits into from
Jan 19, 2024

Conversation

drasmuss
Copy link
Member

No description provided.

This behaviour is now built into Sphinx.
Copy link
Member

@tbekolay tbekolay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All of the extensions seem to be working, which is good, but some of our custom CSS is not working in this branch (but it works in main). Hopefully it's just a matter of updating some selectors, I'll take a look.

@tbekolay
Copy link
Member

Alrighty I pushed the CSS fixes. A few things had changed in the HTML rendered from CSS, and I moved the CSS file here so we didn't have to keep track of what is there for compatibility with previous versions of Sphinx.

I spent a fair bit of time trying to minimize the size of the CSS file, but ultimately wasn't very successful, as we were apparently shipping a customized version of bootstrap, so we couldn't work off the CDN delivered version, and removing bits of unused CSS might trip us up later when we look at the Bootstrap docs to figure out what we can use. It would have been a small optimization in any case, nengo.css is 206kb so in the best case we maybe save 100kb.

Previously the CSS file was served through nengo.ai.
Moving it here simplifies future development, and ensures
that future changes to CSS don't affect older doc builds.
@drasmuss drasmuss merged commit 5376a16 into main Jan 19, 2024
2 checks passed
@drasmuss drasmuss deleted the update-sphinx branch January 19, 2024 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants