Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set body class for sphinx 2.0 compatibility #26

Merged
merged 1 commit into from
Mar 30, 2019
Merged

Set body class for sphinx 2.0 compatibility #26

merged 1 commit into from
Mar 30, 2019

Conversation

drasmuss
Copy link
Member

Apparently sphinx expects the main body to be given the body class (see sphinx-doc/sphinx#6170 (comment)). Previously the fact that we weren't doing this doesn't seem to have made a difference, but as of the sphinx 2.0 release it causes all of the text in tables to be centre-aligned if you don't have this.

Confirmed that this fixes the issue for sphinx 2.0, and doesn't cause a difference in sphinx 1.8.

Copy link
Member

@tbekolay tbekolay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and tables look good to me locally. Merging!

This was apparently always supposed to be the case, but only
caused a bug in the Sphinx 2.0 release.
@tbekolay tbekolay merged commit fb2fe88 into master Mar 30, 2019
@tbekolay tbekolay deleted the fix-align branch March 30, 2019 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants