Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Doc search broken for some queries #28

Closed
arvoelke opened this issue May 6, 2019 · 4 comments · Fixed by #39
Closed

Doc search broken for some queries #28

arvoelke opened this issue May 6, 2019 · 4 comments · Fixed by #39

Comments

@arvoelke
Copy link

arvoelke commented May 6, 2019

Example: https://www.nengo.ai/nengo/search.html?q=Ensemble

JS Console:
Screenshot from 2019-05-06 15-44-11

Other examples with similar (or sometimes the same) errors:

  • Connection
  • PES
  • Learning
  • Uniform
  • tuning
  • gain
  • nengo

Examples that are fine (no error):

  • asd
  • q
  • dt

Similar symptoms for nengo-loihi. Have not checked any others users of nengo-sphinx-theme.
@arvoelke arvoelke mentioned this issue May 6, 2019
Closed
@arvoelke
Copy link
Author

This issue appears to be present in all of the docs.

@hunse
Copy link
Collaborator

hunse commented Aug 1, 2019

Likely the same problem as mli/new-docs#105

@hunse
Copy link
Collaborator

hunse commented Aug 1, 2019

Possibly related to sphinx-doc/sphinx#6387, which should be fixed by sphinx-doc/sphinx#6394 for some themes.

@hunse
Copy link
Collaborator

hunse commented Aug 1, 2019

I think this is fixable by applying the same idea from sphinx-doc/sphinx#6394 to our theme here. However, I haven't been able to test this yet because it only shows up when the docs are online (not locally).

hunse added a commit that referenced this issue Aug 2, 2019
@hunse
Search function no longer hangs
8e3d696 
Fixes #28.
@hunse hunse mentioned this issue Aug 2, 2019
Merged
hunse added a commit that referenced this issue Aug 2, 2019
@hunse
Search function no longer hangs
d14afa8 
Apply changes from sphinx-doc/sphinx#6394 so that pages have
`role="main"` marker that search looks for. Fixes #28.
tbekolay pushed a commit that referenced this issue Aug 5, 2019
@hunse @tbekolay
Fix search function hanging
107e90f 
Fixed by applying the changes from sphinx-doc/sphinx#6394.
Specifically, the main div now has the `role="main" attribute.

Fixes #28.
@tbekolay tbekolay mentioned this issue Aug 6, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Search function no longer hangs nengo/nengo-sphinx-theme
2 participants
@hunse @arvoelke