Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow dummy actions. #191

Merged
merged 1 commit into from
Jul 5, 2018
Merged

Allow dummy actions. #191

merged 1 commit into from
Jul 5, 2018

Conversation

jgosmann
Copy link
Collaborator

@jgosmann jgosmann commented Jul 4, 2018 •
edited
Loading

Motivation and context:
Allows unnamed actions without any effects. Fixes #189.

Interactions with other PRs:
none

How has this been tested?
added tests

How long should this take to review?

  • Quick (less than 40 lines changed or changes are straightforward)

Types of changes:

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • I have read the CONTRIBUTING.rst document.
  • [n/a] I have updated the documentation accordingly.
  • I have included a changelog entry.
  • I have added tests to cover my changes.
  • I have run the test suite locally and all tests passed.

@jgosmann jgosmann added this to the 0.5.2 milestone Jul 4, 2018
@jgosmann jgosmann requested a review from Seanny123 July 4, 2018 18:33
@jgosmann jgosmann self-assigned this Jul 4, 2018
@jgosmann jgosmann removed their assignment Jul 4, 2018
@jgosmann jgosmann merged commit 70c1e09 into master Jul 5, 2018
@jgosmann jgosmann deleted the dummy-action branch July 5, 2018 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Seanny123 Seanny123 Seanny123 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
0.5.2
Development

Successfully merging this pull request may close these issues.

Action selection condition without name requires effect
2 participants
@jgosmann @Seanny123