Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow wider variety of Transcode outputs. #178

Merged
merged 1 commit into from
Jun 7, 2018
Merged

Conversation

jgosmann
Copy link
Collaborator

@jgosmann jgosmann commented Jun 6, 2018

Motivation and context:
This adds support for SemanticPointer and PointerSymbol instances.

Fixes #175.

Interactions with other PRs:
none

How has this been tested?
added tests

How long should this take to review?

  • Quick (less than 40 lines changed or changes are straightforward)

Types of changes:

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • I have read the CONTRIBUTING.rst document.
  • I have updated the documentation accordingly.
  • I have included a changelog entry.
  • I have added tests to cover my changes.
  • I have run the test suite locally and all tests passed.

@jgosmann jgosmann added this to the 0.5.1 milestone Jun 6, 2018
@jgosmann jgosmann requested a review from Seanny123 June 6, 2018 20:53
@jgosmann jgosmann self-assigned this Jun 7, 2018
@jgosmann jgosmann force-pushed the fix-transcode-symbols branch from 9cf218d to 79a7b5b Compare June 7, 2018 14:05
@jgosmann
Copy link
Collaborator Author

jgosmann commented Jun 7, 2018

Rebased and squashed. Added one more commit to update documentation. Looks good to you, @Seanny123?

@Seanny123
Copy link
Collaborator

Yep. Go ahead and merge.

This adds support for SemanticPointer and PointerSymbol instances.

Fixes #175.
@jgosmann jgosmann force-pushed the fix-transcode-symbols branch from b71892f to 7fb9e8d Compare June 7, 2018 14:10
@jgosmann jgosmann merged commit 30fa5f5 into master Jun 7, 2018
@jgosmann jgosmann deleted the fix-transcode-symbols branch June 7, 2018 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Transcode outputs should allow pointer symbols
2 participants