Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary argument in Transcode functions. #134

Merged
merged 1 commit into from
Feb 26, 2018
Merged

Conversation

jgosmann
Copy link
Collaborator

@jgosmann jgosmann commented Feb 21, 2018

Motivation and context:
With the new syntax, SemanticPointer can track their vocabulary. This makes the vocab argument in Transcode functions unneccessary as it can be retrieved from the Semantic Pointer that is passed in.

Interactions with other PRs:
Cherry-picked the commit from my local docs branch as it touches actual code and should be reviewed separately. Thus the same commit might at some point appear in PR #68.

How has this been tested?
existing tests

How long should this take to review?

  • Quick (less than 40 lines changed or changes are straightforward)

Types of changes:

  • Breaking change (fix or feature that causes existing functionality to change)

Checklist:

  • I have read the CONTRIBUTING.rst document.
  • [n/a] I have updated the documentation accordingly.
  • [n/a] I have included a changelog entry.
  • [n/a] I have added tests to cover my changes.
  • I have run the test suite locally and all tests passed.

@jgosmann jgosmann added this to the 0.4 release milestone Feb 21, 2018
@jgosmann jgosmann requested a review from Seanny123 February 21, 2018 22:26
@jgosmann jgosmann self-assigned this Feb 22, 2018
@Seanny123 Seanny123 mentioned this pull request Feb 22, 2018
9 tasks
@jgosmann
Copy link
Collaborator Author

AppVeyor build is failing due to some conda/openblas f*** up (once again). 😠 Merging.

@jgosmann jgosmann merged commit b721f74 into master Feb 26, 2018
@jgosmann jgosmann deleted the transcode-arg branch February 26, 2018 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants