Naming of ifmax actions #133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If it fails all further ActionSelection contexts would raise an exception. This is a problem when running tests where this exception is raised on purpose or interactive environments.
Addresses #132.
Seanny123
approved these changes
Feb 21, 2018
|
Squashed, fixed grammar, and added a commit to make CI tests pass. Will merge upon successful completion. |
|
FYI, the TravisCI tests have passed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and context:
Allows the naming of ifmax actions by providing an optional string as first argument to
ifmax.Furthermore,
ActionSelectionimplements the dictionary interface. This allows to get the names with thekeys()method (in some context the result might need an explicit cast tolist(action_sel.keys())). Actions without a name will be assigned an integer index in this sequence.ActionSelectioncan either be indexed with the string names or integer indices to retrieve the corresponding utility input nodes.Closes #132.
Interactions with other PRs:
#68 should be rebased once this PR has been merged.
How has this been tested?
Added a test.
How long should this take to review?
Types of changes:
Checklist: