Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enable eager mode #163

Merged
merged 5 commits into from
Aug 13, 2020
Merged

Re-enable eager mode #163

merged 5 commits into from
Aug 13, 2020

Conversation

drasmuss
Copy link
Member

@drasmuss drasmuss commented Jul 20, 2020

We had disabled eager mode for performance reasons, but there have been some recent performance improvements so we're trying it out again.

This also necessitated some changes to how the build system is set up. Since the TensorGraph.call function may be called multiple times in eager mode, rather than once per graph, we need to separate the OpBuilder.__init__(which we only want to happen once) from the new OpBuilder.build_pre (which we want to happen each time call is executed).

Fixes #160 (in that in eager-mode you can create constants larger than 2GB; the problem persists in graph mode, but that's just a limitation of graph mode).

Fixes #156 (in eager mode; as above, problem persists in graph mode but I don't think it's worth looking into any further there as it's an underlying problem with TensorFlow's graph mode).

Fixes #109 (in eager mode, same as above).

@drasmuss drasmuss force-pushed the enable-eager branch 3 times, most recently from ed5d8d8 to 88fdb70 Compare July 22, 2020 18:32
@drasmuss drasmuss force-pushed the enable-eager branch 2 times, most recently from b2267b0 to 8e15af5 Compare July 22, 2020 22:46
Base automatically changed from converter-2.3 to master July 29, 2020 18:00
@drasmuss drasmuss force-pushed the enable-eager branch 14 times, most recently from e9728d4 to 2f465c6 Compare August 4, 2020 14:07
Copy link
Collaborator

@hunse hunse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few questions and minor comments. Nothing that needs to be changed, though, so I'll approve this now.

nengo_dl/callbacks.py Outdated Show resolved Hide resolved
nengo_dl/graph_optimizer.py Outdated Show resolved Hide resolved
nengo_dl/simulator.py Outdated Show resolved Hide resolved
nengo_dl/tensor_graph.py Show resolved Hide resolved
nengo_dl/tests/test_builder.py Outdated Show resolved Hide resolved
Copy link
Member

@tbekolay tbekolay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good to me. I resolved all of Eric's comments that were done, but I think there's one left; are you still working on that @drasmuss or is that being made into a separate story? All suggested changes are done; fixing up then merging!

@tbekolay tbekolay merged commit b27caa0 into master Aug 13, 2020
@tbekolay tbekolay deleted the enable-eager branch August 13, 2020 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants