Add support for UpSampling layers to converter #130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drasmuss
force-pushed
the
upsample
branch
2 times, most recently
from
f6f84bb to
13f9024
Compare
hunse
reviewed
Mar 5, 2020
| bias_relay, | ||
| output, | ||
| transform=nengo.Sparse( | ||
| (output.size_in, bias_relay.size_out), indices=broadcast_indices |
There was a problem hiding this comment.
I would explicitly set init=1 here, just to make it clear what the sparse values are.
There was a problem hiding this comment.
I assumed that it was 1, personally. If we thought it would be ambiguous we should have made init a required argument in nengo.Sparse, but since that didn't come up when working on that, I feel like it's what we would naturally assume.
This was accidentally removed at some point in the 3.0 rewrite.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.