Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for transform=None #128

Merged
merged 3 commits into from
Mar 4, 2020
Merged

Support for transform=None #128

merged 3 commits into from
Mar 4, 2020

Conversation

drasmuss
Copy link
Member

Adds NengoDL support for the transform=None changes in Nengo core (nengo/nengo#1591).

@drasmuss
Copy link
Member Author

See #119 (comment) for a note on the performance changes.

@drasmuss drasmuss force-pushed the transform-none branch 2 times, most recently from 34cfc43 to 9256848 Compare January 23, 2020 23:55
@tbekolay tbekolay changed the base branch from converter2 to master March 4, 2020 15:28
tbekolay
tbekolay approved these changes Mar 4, 2020
View reviewed changes
Copy link
Member

@tbekolay tbekolay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Will merge when CI passes.

drasmuss and others added 3 commits March 4, 2020 13:55
@tbekolay tbekolay merged commit e79128f into master Mar 4, 2020
@tbekolay tbekolay deleted the transform-none branch March 4, 2020 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tbekolay tbekolay tbekolay approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@drasmuss @tbekolay