Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for one_page sphinx theme option #101

Merged
merged 1 commit into from
Apr 17, 2020
Merged

Add support for one_page sphinx theme option #101

merged 1 commit into from
Apr 17, 2020

Conversation

drasmuss
Copy link
Member

Motivation and context:

Adds support for the new configuration option added in nengo/nengo-sphinx-theme#59

Interactions with other PRs:

Depends on nengo/nengo-sphinx-theme#59, and downstream repos will be added in the projects that use the one_page option.

How has this been tested?

Added to config notebook, and functionality will be tested in the downstream repos.

How long should this take to review?

  • Quick (less than 40 lines changed or changes are straightforward)

Types of changes:

  • New feature (non-breaking change which adds functionality)

Checklist:

  • I have read the CONTRIBUTING.rst document.
  • I have updated the documentation accordingly.
  • I have included a changelog entry.
  • I have added tests to cover my changes.
  • I have run the test suite locally and all tests passed.

@hunse hunse merged commit 397493f into master Apr 17, 2020
@hunse hunse deleted the one-page branch April 17, 2020 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants