Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cite A Spike In Performance in SpikingActivation #30

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

hunse
Copy link
Contributor

@hunse hunse commented Oct 2, 2023

We do this in Nengo's RegularSpiking, but somehow missed doing it here, so I just copied the citation from there.

@hunse hunse requested a review from drasmuss October 2, 2023 19:40
@hunse hunse force-pushed the doc-spike-in-performance branch from 87a1283 to 88c27cf Compare October 3, 2023 14:54
Copy link
Member

@drasmuss drasmuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM. CI is failing, but that's unrelated to this change. If you have time could try to get things passing, or it'd also be fine to just go ahead and merge since these are docstring only changes.

@hunse hunse force-pushed the doc-spike-in-performance branch from 88c27cf to 1443c45 Compare January 19, 2024 18:32
@hunse hunse force-pushed the doc-spike-in-performance branch from ba3ddce to 7c0e407 Compare January 22, 2024 14:09
Copy link

Coverage report

The coverage rate went from 100% to 100% ➡️

100% of new lines are covered.

Diff Coverage details (click to unfold)

keras_spiking/version.py

100% of new lines are covered (100% of the complete file).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants