This repository has been archived by the owner on Jan 8, 2024. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use case:
We use the Aurora scheduler in Mesos which assign tasks names using a
jobkey which consists of: "role/environment/jobname". We often end up
in a scenario where we want all jobs running under a given "role" or
"role/environment" combination to have access to a Vault role. Under
the current implementation this would require us to iterate all of the
possible combination and install policy files.
Previous versions of Vault gatekeeper allowed us to do wildcards with
prefixes as they used a simple glob match. Moving to the radix tree
implementation broke this behaviour.
This patch changes the matching behaviour slightly. Whenever we detect
a wildcard match we flag the policy as such.
When performing policy matching for wildcards we do a prefix search,
rather than looking for the last character being ":". Policy matching
for non wildcard policies is unchanged.
No changes to the radix tree structure are required.