This repository has been archived by the owner on Jan 8, 2024. It is now read-only.
Adding support for glob matching of policies #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nemosupremo
reviewed
Oct 13, 2016
| // Order the keys in descending order of length | ||
| // so that "foobar*" takes precedence over "foo*" | ||
| // Now organize the keys by length | ||
| policyKeys := make(policyKeyList, 0, ) |
There was a problem hiding this comment.
Does this line compile? I'm not familiar with this syntax.
There was a problem hiding this comment.
Apparently it does, although I didn't mean to leave that comma in. I took it out.
|
I had a single comment - an initial review of the code looks good, but it doesn't look like you've tried to compile it. Could you also make sure to |
|
It does compile and work, although I didn't mean to leave that comma in there. I formatted the file and updated the PR. Thanks! |
|
Thanks for your contribution! I really see how this could help, especially because I don't think Chronos uses easy to guess task names. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi all,
We have a large number of Chronos jobs that all need Vault tokens. Specifying each name individually is unsupportable, so I've added functionality to support glob patterns in policy names. I've updated the README to show an example.