feat: [5.x] attribute consistency #2368
Conversation
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## 5.x #2368 +/- ##
=======================================
Coverage 89.33% 89.33%
=======================================
Files 73 73
Lines 2775 2775
=======================================
Hits 2479 2479
Misses 296 296 ☔ View full report in Codecov by Sentry. |
UPGRADE-5.0.md
Outdated
|
|
||
| ## BC BREAK: `Nelmio\ApiDocBundle\Annotation` namespace has been moved to `Nelmio\ApiDocBundle\Attribute` | ||
|
|
||
| ## BC BREAK: Configuration option `with_annotation` has been renamed to `with_attribute` | ||
| ```diff | ||
| nelmio_api_doc: | ||
| areas: | ||
| path_patterns: | ||
| - ^/api/foo | ||
| - with_annotation: true | ||
| + with_attribute: true | ||
| ``` |
There was a problem hiding this comment.
TODO: Migration path in 4.x
There was a problem hiding this comment.
Probably is better implement recipes (https://github.com/symfony/recipes-contrib/tree/main/nelmio/api-doc-bundle) for 5.x version and replace that attribute with it
There was a problem hiding this comment.
with_attribute is still an optional config option so adding it as a recipe won't do much
| Q | A | |---------------|---------------------------------------------------------------------------------------------------------------------------| | Bug fix? | no | | New feature? | no <!-- please update src/**/CHANGELOG.md files --> | | Deprecations? | yes | Migration for annotations to attributes #2368 (comment)
Cleanup various references to annotations to their attribute variant
#2215