docs: update symfony_attributes.rst with info about required library #2289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Found out that MapQueryString Attribute doesn't work without component symfony/property-access (ObjectNormalizer::class). And there is no info in doc about that, also the problem is not obvious for regular MapQueryString users as the exception highlight only that there is no normalizer that supports this
Oni4i
changed the title
DjordyKoert
reviewed
May 29, 2024
|
|
||
| .. code-block:: terminal | ||
|
|
||
| $ composer require symfony/property-access |
There was a problem hiding this comment.
I think you mean the property-info component instead of property-access. property-access isn't used anywhere in this project.
Also symfony/property-info should be installed together with this project because it's required in package.json https://github.com/nelmio/NelmioApiDocBundle/blob/9379c44da4b4e6ef36a81f3135d3d158838a7c16/composer.json#L29C10-L29C31
DjordyKoert
changed the title
ToastM8
approved these changes
Aug 1, 2024
ToastM8
reviewed
Aug 1, 2024
ToastM8
approved these changes
Aug 1, 2024
|
/ #2289 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found out that MapQueryString Attribute doesn't work without component symfony/property-access (ObjectNormalizer::class). And there is no info in doc about that, also the problem is not obvious for regular MapQueryString users as the exception highlight only that there is no normalizer that supports this