Boost bzlmod compatibility patch #562
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pendent private targets, meaning hdrs use workspace based pathing (no issues when being used via override), no project "includes" pollution and strip include prefix for each path.
* master: (106 commits) chore(deps): update openssl digest to 0f1a639 chore(deps): update dependency bazel_skylib to v1.6.1 chore(deps): update dependency bazel_skylib to v1.6.0 chore(deps): update openssl digest to 1518c66 chore(deps): update openssl digest to 23b6cb8 chore(deps): update openssl digest to e39ac22 chore(deps): update openssl digest to 81b33dd chore(deps): update openssl digest to dfbc37f chore(deps): update openssl digest to 6e8e87e chore(deps): update openssl digest to e761ca4 chore(deps): update openssl digest to 8c597d5 chore(deps): update openssl digest to c51f299 chore(deps): update openssl digest to 8cbad75 chore(deps): update openssl digest to a8ebd53 Downgrade lzma (#556) chore(deps): update openssl digest to 30c15fb chore(deps): update openssl digest to 604c477 chore(deps): update openssl digest to 6bed03a chore(deps): update dependency com_github_facebook_zstd to v1.5.6 chore(deps): update openssl digest to 321dd35 ...
|
Usage in |
mmorel-35
reviewed
May 21, 2024
| @@ -0,0 +1,18 @@ | |||
| module(name = "boost", repo_name = "com_github_nelhage_rules_boost") | |||
There was a problem hiding this comment.
What do you think about this as rules_boost os the project name ?
Suggested change
| module(name = "boost", repo_name = "com_github_nelhage_rules_boost") | |
| module(name = "rules_boost", repo_name = "com_github_nelhage_rules_boost") |
mmorel-35
reviewed
May 21, 2024
| use_repo(boost_libs, "org_bzip_bzip2") | ||
| # use_repo(boost_libs, "org_lzma_lzma") # TODO is this backwards compatible with workspace? | ||
| use_repo(boost_libs, "com_github_facebook_zstd") | ||
| use_repo(boost_libs, "openssl") |
There was a problem hiding this comment.
Why not using bazel_deps with custom repo_names for existing libraries in the BCR ?
|
Closed since #553 is merged now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires testing for backwards compatibility with workspace. Adding PR due to interest in #553