Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: reverted jest upgrade (#427) #2

Merged
merged 1 commit into from
Jan 19, 2024

Conversation

andrey-canon
Copy link
Collaborator

Description

This is a backport of openedx#427 and this is necessary to make this version compatible with the frontend-app-learning palm branch

Before

https://github.com/nelc/frontend-app-learning/actions/runs/7576478448

After

https://github.com/nelc/frontend-app-learning/actions/runs/7587312436

Copy link

@johanseto johanseto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you installed in you local env. I think, package lock json file update is mssing to pass the tests?

@andrey-canon
Copy link
Collaborator Author

andrey-canon commented Jan 19, 2024

Did you installed in you local env. I think, package lock json file update is mssing to pass the tests?

Yes, you were right the package lock json file was missing, I've just added

@johanseto johanseto self-requested a review January 19, 2024 21:50
@andrey-canon andrey-canon merged commit 0c8b490 into open-release/palm.nelp Jan 19, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants