Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for GHA services #775

Closed
wants to merge 7 commits into from

Conversation

catthehacker
Copy link
Member

@catthehacker catthehacker commented Aug 11, 2021

Original PR: #638
Fixes #173

Changes:

  • add support for services
  • creates network linked between all containers
  • fixes job context to include container and services contexts

To do:

  • Add more testcases
  • Multiple sanity checks that code doesn't look terrible
  • Fix job context

@mergify

This comment has been minimized.

@mergify mergify bot added the needs-work Extra attention is needed label Aug 11, 2021
@codecov
Copy link

codecov bot commented Aug 11, 2021

Codecov Report

Merging #775 (453d1f0) into master (0f04942) will increase coverage by 7.07%.
The diff coverage is 59.90%.

❗ Current head 453d1f0 differs from pull request most recent head 90a47e9. Consider uploading reports for the commit 90a47e9 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #775      +/-   ##
==========================================
+ Coverage   49.27%   56.34%   +7.07%     
==========================================
  Files          23       29       +6     
  Lines        2401     4316    +1915     
==========================================
+ Hits         1183     2432    +1249     
- Misses       1090     1677     +587     
- Partials      128      207      +79     
Impacted Files Coverage Δ
pkg/common/executor.go 46.90% <0.00%> (+2.03%) ⬆️
pkg/common/job_error.go 0.00% <0.00%> (ø)
pkg/common/outbound_ip.go 0.00% <0.00%> (ø)
pkg/common/testflag.go 0.00% <0.00%> (ø)
pkg/container/docker_network.go 0.00% <0.00%> (ø)
pkg/container/docker_volume.go 0.00% <0.00%> (ø)
pkg/model/action.go 0.00% <ø> (ø)
pkg/container/docker_run.go 5.15% <9.24%> (+3.22%) ⬆️
pkg/common/git.go 49.82% <31.81%> (-9.97%) ⬇️
pkg/runner/logger.go 65.43% <37.50%> (+1.28%) ⬆️
... and 36 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4e0ba61...90a47e9. Read the comment docs.

@catthehacker catthehacker added the stale-exempt Exempt from stale label Aug 11, 2021
@catthehacker catthehacker self-assigned this Aug 11, 2021
@till
Copy link
Contributor

till commented Nov 5, 2021

Can you rebase this PR? 😀

@mergify

This comment has been minimized.

@mergify mergify bot removed the needs-work Extra attention is needed label Nov 5, 2021
@mergify

This comment has been minimized.

@mergify mergify bot added the conflict PR has conflicts label Nov 27, 2021
@mergify mergify bot removed the conflict PR has conflicts label Dec 3, 2021
@catthehacker catthehacker force-pushed the cat/feat/services branch 6 times, most recently from cd0cfc9 to 453d1f0 Compare December 20, 2021 02:11
@catthehacker catthehacker marked this pull request as ready for review December 20, 2021 02:17
@catthehacker catthehacker requested a review from a team as a code owner December 20, 2021 02:17
@catthehacker catthehacker marked this pull request as draft December 20, 2021 02:25
Signed-off-by: hackercat <[email protected]>
@acorncom
Copy link

Is this or something like it likely to land or does it not have a future? Would love to use services in a new CD workflow I'm setting up ...

@KnisterPeter
Copy link
Member

@acorncom I think a PR is more than welcome. But it is not the smallest topic 😉

@acorncom
Copy link

@KnisterPeter I gathered 😉 Afraid I probably can't help with it right now sadly ...

@catthehacker
Copy link
Member Author

This PR is almost complete, the only thing missing is that it breaks after fixing job context

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/L stale-exempt Exempt from stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Services not working
6 participants