-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove .gitignore before docker cp #288
remove .gitignore before docker cp #288
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
I'm sorry to report it, but it does not work for windows 10 x64. Literally seems like path are being treated as strings so no hierarchy, no directories, just listing of files. |
Hey there :) any chance this might be more related to #180 ? As I understand it .gitignore is gone for good and it might be path normalization related ? |
Will hopefully fix #228
This patch checks for the presence of a
.gitignore
file in a remote repository action, and removes it before runningdocker cp
.I'm not too aware of how the project works and its structure, I'm not even sure that's the way you'd like to address this issue, so please let me know how you feel about it, and feel free to discard it or ask me for edits :)
Thanks again for your time