Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove .gitignore before docker cp #288

Merged
merged 2 commits into from
Jun 23, 2020

Conversation

o0Ignition0o
Copy link
Contributor

Will hopefully fix #228

This patch checks for the presence of a .gitignore file in a remote repository action, and removes it before running docker cp.

I'm not too aware of how the project works and its structure, I'm not even sure that's the way you'd like to address this issue, so please let me know how you feel about it, and feel free to discard it or ask me for edits :)

Thanks again for your time

@o0Ignition0o o0Ignition0o requested a review from cplee as a code owner June 21, 2020 19:38
@o0Ignition0o o0Ignition0o changed the title .gitignore before docker cp remove .gitignore before docker cp Jun 21, 2020
Copy link
Contributor

@cplee cplee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@cplee cplee merged commit 7cc6687 into nektos:master Jun 23, 2020
@o0Ignition0o o0Ignition0o deleted the igni/remove_gitignore_before_cp branch June 23, 2020 22:04
@szusik
Copy link

szusik commented Jul 3, 2020

I'm sorry to report it, but it does not work for windows 10 x64.
I think .gitignore is really gone but.... this is how docker image content looks like:
root@docker-desktop:/actions# ls -alh /actions
total 1.6M
drwxr-xr-x 2 root root 4.0K Jul 3 11:17 .
drwxr-xr-x 1 root root 4.0K Jul 3 11:17 ..
-rw-rw-rw- 1 root root 41 Jul 3 11:17 '[email protected]\HEAD'
-rw-rw-rw- 1 root root 191 Jul 3 11:17 '[email protected]\config'
-rw-rw-rw- 1 root root 1.9K Jul 3 11:17 '[email protected]\index'
-rw-rw-rw- 1 root root 27K Jul 3 11:17 '[email protected]\objects\pack\pack-e9cf09f8eda81d8eb47d2777306bd5133077983d.idx'
-rw-rw-rw- 1 root root 901K Jul 3 11:17 '[email protected]\objects\pack\pack-e9cf09f8eda81d8eb47d2777306bd5133077983d.pack'
-rw-rw-rw- 1 root root 41 Jul 3 11:17 '[email protected]\refs\heads\master'
-rw-rw-rw- 1 root root 41 Jul 3 11:17 '[email protected]\refs\remotes\origin\master'
-rw-rw-rw- 1 root root 41 Jul 3 11:17 '[email protected]\refs\remotes\origin\releases\v1'
-rw-rw-rw- 1 root root 41 Jul 3 11:17 '[email protected]\refs\tags\v1'
-rw-rw-rw- 1 root root 41 Jul 3 11:17 '[email protected]\refs\tags\v1.0'
-rw-rw-rw- 1 root root 41 Jul 3 11:17 '[email protected]\refs\tags\v1.0.0'
-rw-rw-rw- 1 root root 41 Jul 3 11:17 '[email protected]\refs\tags\v1.0.1'
-rw-rw-rw- 1 root root 41 Jul 3 11:17 '[email protected]\refs\tags\v1.1.0'
-rw-rw-rw- 1 root root 41 Jul 3 11:17 '[email protected]\refs\tags\v1.2.0'
-rw-rw-rw- 1 root root 41 Jul 3 11:17 '[email protected]\refs\tags\v1.3.0'
-rw-rw-rw- 1 root root 71 Jul 3 11:17 '[email protected]'
-rw-rw-rw- 1 root root 296 Jul 3 11:17 '[email protected]\java.json'
-rw-rw-rw- 1 root root 280 Jul 3 11:17 '[email protected]\workflows\lint-yaml.yml'
-rw-rw-rw- 1 root root 517 Jul 3 11:17 '[email protected]\workflows\workflow.yml'
-rw-rw-rw- 1 root root 224 Jul 3 11:17 '[email protected]'
-rw-rw-rw- 1 root root 1.1K Jul 3 11:17 'actions-setup-java@v1\LICENSE'
-rw-rw-rw- 1 root root 6.0K Jul 3 11:17 'actions-setup-java@v1\README.md'
-rw-rw-rw- 1 root root 4.3K Jul 3 11:17 'actions-setup-java@v1_tests_\auth.test.ts'
-rw-rw-rw- 1 root root 5.2K Jul 3 11:17 'actions-setup-java@v1_tests_\installer.test.ts'
-rw-rw-rw- 1 root root 1.4K Jul 3 11:17 'actions-setup-java@v1\action.yml'
-rw-rw-rw- 1 root root 156K Jul 3 11:17 'actions-setup-java@v1\dist\index.js'
-rw-rw-rw- 1 root root 171K Jul 3 11:17 'actions-setup-java@v1\dist\unzip'
-rw-rw-rw- 1 root root 1.3K Jul 3 11:17 'actions-setup-java@v1\docs\contributors.md'
-rw-rw-rw- 1 root root 235 Jul 3 11:17 'actions-setup-java@v1\jest.config.js'
-rw-rw-rw- 1 root root 186K Jul 3 11:17 'actions-setup-java@v1\package-lock.json'
-rw-rw-rw- 1 root root 1.2K Jul 3 11:17 'actions-setup-java@v1\package.json'
-rw-rw-rw- 1 root root 2.0K Jul 3 11:17 'actions-setup-java@v1\src\auth.ts'
-rw-rw-rw- 1 root root 8.3K Jul 3 11:17 'actions-setup-java@v1\src\installer.ts'
-rw-rw-rw- 1 root root 1.1K Jul 3 11:17 'actions-setup-java@v1\src\setup-java.ts'
-rw-rw-rw- 1 root root 5.6K Jul 3 11:17 'actions-setup-java@v1\tsconfig.json'
-rw-rw-rw- 1 root root 137 Jul 3 11:17 'actions-setup-java@v1\yaml-lint-config.yml'

Literally seems like path are being treated as strings so no hierarchy, no directories, just listing of files.

@o0Ignition0o
Copy link
Contributor Author

Hey there :) any chance this might be more related to #180 ?

As I understand it .gitignore is gone for good and it might be path normalization related ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MODULE_NOT_FOUND during docker cp command
3 participants