-
-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow PHP 8.2 and 8.3 for 4.x series of the module #565
Conversation
release 4.2.13 of spatie/phpunit-snapshot-assertions started dropping the Doctype head from the output, so all snapshots need to be updated, see https://github.com/spatie/phpunit-snapshot-assertions/releases/tag/4.2.13 for further information
15ba5d5
to
9077cff
Compare
7de8002
to
bfad342
Compare
note that for PHP 8.2 a few build tools around PhpStan needed to be updated, which makes dropping PHP 7.4 mandatory
bfad342
to
c591e80
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 4.x #565 +/- ##
============================================
+ Coverage 89.04% 89.18% +0.14%
Complexity 1147 1147
============================================
Files 60 60
Lines 2820 3698 +878
============================================
+ Hits 2511 3298 +787
- Misses 309 400 +91 ☔ View full report in Codecov by Sentry. |
For a bit of a background on this story, we still use Bootstrap 4 in a few of our applications. Therefore, I would much appreciate if you could merge this PR and tag a new release from the 4.x branch, which would allow using the Boostrap 4 version of this module with PHP 8.2 and PHP 8.3. With #566 I have made a second PR which adds support for PHP 8.3 with the Bootstrap 5 version of this module as well. |
Thanks, @neilime! 🚀 |
This PR proposes a minor release from the 4.x branch (i.e. 4.2.0).
Added
Removed