Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow PHP 8.2 and 8.3 for 4.x series of the module #565

Merged
merged 4 commits into from
Dec 22, 2023

Conversation

driehle
Copy link
Contributor

@driehle driehle commented Dec 6, 2023

This PR proposes a minor release from the 4.x branch (i.e. 4.2.0).

Added

  • Support for PHP 8.2
  • Support for PHP 8.3

Removed

  • Support for PHP 7.4

release 4.2.13 of spatie/phpunit-snapshot-assertions started dropping the
Doctype head from the output, so all snapshots need to be updated, see
https://github.com/spatie/phpunit-snapshot-assertions/releases/tag/4.2.13
for further information
@driehle driehle force-pushed the feat/4.x-php-8.2 branch 3 times, most recently from 7de8002 to bfad342 Compare December 6, 2023 10:15
note that for PHP 8.2 a few build tools around PhpStan needed to be
updated, which makes dropping PHP 7.4 mandatory
Copy link

codecov bot commented Dec 6, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8de90b3) 89.04% compared to head (c591e80) 89.18%.

❗ Current head c591e80 differs from pull request most recent head 3b13b09. Consider uploading reports for the commit 3b13b09 to get more accurate results

Additional details and impacted files
@@             Coverage Diff              @@
##                4.x     #565      +/-   ##
============================================
+ Coverage     89.04%   89.18%   +0.14%     
  Complexity     1147     1147              
============================================
  Files            60       60              
  Lines          2820     3698     +878     
============================================
+ Hits           2511     3298     +787     
- Misses          309      400      +91     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@driehle driehle changed the title Allow PHP 8.2 for 4.x series of the module Allow PHP 8.2 and 8.3 for 4.x series of the module Dec 6, 2023
@driehle driehle marked this pull request as ready for review December 6, 2023 10:27
@driehle
Copy link
Contributor Author

driehle commented Dec 6, 2023

@neilime

For a bit of a background on this story, we still use Bootstrap 4 in a few of our applications. Therefore, I would much appreciate if you could merge this PR and tag a new release from the 4.x branch, which would allow using the Boostrap 4 version of this module with PHP 8.2 and PHP 8.3.

With #566 I have made a second PR which adds support for PHP 8.3 with the Bootstrap 5 version of this module as well.

@neilime neilime merged commit b2b7e3c into neilime:4.x Dec 22, 2023
4 checks passed
@driehle driehle deleted the feat/4.x-php-8.2 branch December 29, 2023 11:37
@driehle
Copy link
Contributor Author

driehle commented Dec 29, 2023

Thanks, @neilime! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants