Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove phpstan outdated ignored issue #493

Merged
merged 1 commit into from
May 5, 2023
Merged

fix: remove phpstan outdated ignored issue #493

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,9 @@ lint: ## Execute lint for given PHP version
lint-fix: ## Execute lint fixing for given PHP version
@$(call run-php,$(filter-out $@,$(MAKECMDGOALS)) composer cbf)

stan: ## Execute PHPStan for given PHP version
@$(call run-php,$(filter-out $@,$(MAKECMDGOALS)) composer stan)

ci: ## Execute CI scripts for given PHP version
@$(call run-php,$(filter-out $@,$(MAKECMDGOALS)) composer ci)

Expand Down
2 changes: 0 additions & 2 deletions phpstan.neon
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,4 @@
parameters:
ignoreErrors:
- '/Access to an offset on an unknown class Laminas\\ServiceManager\\InitializersConfigurationType/'
laminasframework:
serviceManagerLoader: tests/phpstan.php
excludePaths:
Expand Down
1 change: 0 additions & 1 deletion src/TwbsHelper/View/Helper/HtmlAttributes/HtmlClass/HelperPluginManager.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,6 @@ class HelperPluginManager extends \Laminas\ServiceManager\AbstractPluginManager
*
* @var array
*/
/** @phpstan-ignore-next-line */
protected $factories = [
\TwbsHelper\View\Helper\HtmlAttributes\HtmlClass\Helper\Align::class
=> \Laminas\ServiceManager\Factory\InvokableFactory::class,
Expand Down